Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

codec(ticdc): update goavro to 2.11.1 to solve avro decimal encoding bug #5556

Merged
merged 8 commits into from
May 24, 2022
Merged

codec(ticdc): update goavro to 2.11.1 to solve avro decimal encoding bug #5556

merged 8 commits into from
May 24, 2022

Conversation

zhangyangyu
Copy link
Member

@zhangyangyu zhangyangyu commented May 24, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: close #5554

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note 

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 24, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hi-rustin
  • zhaoxinyu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-triage-completed release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels May 24, 2022
@zhangyangyu
Copy link
Member Author

/run-all-tests

@ti-chi-bot ti-chi-bot added needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. and removed do-not-merge/needs-triage-completed labels May 24, 2022
@zhangyangyu
Copy link
Member Author

/run-dm-integration-test

@zhangyangyu
Copy link
Member Author

/run-verify

@zhangyangyu
Copy link
Member Author

/run-dm-integration-test

@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 24, 2022
@zhangyangyu
Copy link
Member Author

/run-all-tests

@zhangyangyu
Copy link
Member Author

/run-dm-integration-test

@zhangyangyu
Copy link
Member Author

/run-verify

@zhangyangyu
Copy link
Member Author

/run-all-tests

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 24, 2022
@zhangyangyu
Copy link
Member Author

/run-all-tests

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 24, 2022
@ti-chi-bot
Copy link
Member

@nongfushanquan: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@Rustin170506
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: b205c05

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 24, 2022
@zhangyangyu
Copy link
Member Author

/run-verify

@ti-chi-bot
Copy link
Member

@zhangyangyu: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 745d924 into pingcap:master May 24, 2022
@ti-chi-bot ti-chi-bot mentioned this pull request May 24, 2022
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #5579.

@zhangyangyu zhangyangyu deleted the update-goavro branch May 24, 2022 13:46
ti-chi-bot added a commit that referenced this pull request May 25, 2022
@ti-chi-bot
codec(ticdc): update goavro to 2.11.1 to solve avro decimal encoding …
afe4104 
…bug (#5556) (#5579)

close #5554
@zhangyangyu zhangyangyu mentioned this pull request May 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nongfushanquan nongfushanquan nongfushanquan approved these changes

@Rustin170506 Rustin170506 Rustin170506 approved these changes

@zhaoxinyu zhaoxinyu zhaoxinyu approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
5 participants
@zhangyangyu @ti-chi-bot @Rustin170506 @zhaoxinyu @nongfushanquan