Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

externalresource(engine): Integrate all parts related to GC (Part I) #5596

Merged
merged 11 commits into from
May 27, 2022
Merged

externalresource(engine): Integrate all parts related to GC (Part I) #5596

merged 11 commits into from
May 27, 2022

Conversation

liuzix
Copy link
Contributor

@liuzix liuzix commented May 25, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #5513

What is changed and how it works?

  • Implemented LocalFileResourceController
  • Implemented mockCluster and some integration tests for GC.
  • Minor adjustments of method names.
  • Fixed minor bugs.

Check List

Tests

  • Unit test
  • Integration test

Release note 

None.

@liuzix liuzix added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 25, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 25, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • amyangfei
  • maxshuang

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 25, 2022
@ti-chi-bot ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 26, 2022
@liuzix liuzix changed the title (WIP) externalresource(engine): Integrate all parts related to GC (Part I) externalresource(engine): Integrate all parts related to GC (Part I) May 26, 2022
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 26, 2022
@liuzix liuzix added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. area/engine Issues or PRs related to Dataflow Engine. status/ptal Could you please take a look? labels May 26, 2022
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/needs-linked-issue do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels May 26, 2022
@maxshuang
Copy link
Contributor

rest LGTM.

@codecov-commenter
Copy link

codecov-commenter commented May 26, 2022 •
edited
Loading

Codecov Report

Merging #5596 (ce4d1b1) into master (fcea4d5) will increase coverage by 0.3077%.
The diff coverage is 60.9478%.

Flag Coverage Δ
cdc 61.9513% <63.3663%> (+0.8032%) ⬆️
dm 52.0466% <54.5054%> (+0.0039%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master      #5596        +/-   ##
================================================
+ Coverage   56.0768%   56.3846%   +0.3077%     
================================================
  Files           535        530         -5     
  Lines         70143      69808       -335     
================================================
+ Hits          39334      39361        +27     
+ Misses        27078      26710       -368     
- Partials       3731       3737         +6

amyangfei
amyangfei reviewed May 27, 2022
View reviewed changes
engine/client/executor_client.go
)

// ExecutorClient defines an interface that supports sending gRPC from server
// master to executor.
type ExecutorClient interface {
baseExecutorClient
// baseExecutorClient
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this not used any more

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. It seems baseExecutorClient should not be part of the public interface.

maxshuang
maxshuang reviewed May 27, 2022
View reviewed changes
engine/pkg/externalresource/resourcetypes/interfaces.go

// ResourceTypeController is an interface providing relevant operations related
// to one resource type.
type ResourceTypeController interface {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO, why not the ResourceTypeHandler since it only has GetHandler interface?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More methods are planned in future PRs.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 27, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 27, 2022
@liuzix
Copy link
Contributor Author

liuzix commented May 27, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 4e62af3

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 27, 2022
@amyangfei
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

@liuzix: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@liuzix
Copy link
Contributor Author

liuzix commented May 27, 2022

/run-verify

@ti-chi-bot ti-chi-bot merged commit 2e75a32 into pingcap:master May 27, 2022
@liuzix liuzix mentioned this pull request Jun 1, 2022
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxshuang maxshuang maxshuang approved these changes

@amyangfei amyangfei amyangfei approved these changes

@sleepymole sleepymole Awaiting requested review from sleepymole

@lance6716 lance6716 Awaiting requested review from lance6716

Assignees
No one assigned
Labels
area/engine Issues or PRs related to Dataflow Engine. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. status/ptal Could you please take a look?
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@liuzix @ti-chi-bot @maxshuang @codecov-commenter @amyangfei