Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kafka sink: fix data race in kafka sink #565

Merged
merged 1 commit into from
May 13, 2020
Merged

kafka sink: fix data race in kafka sink #565

merged 1 commit into from
May 13, 2020

Conversation

zier-one
Copy link
Contributor

@zier-one zier-one commented May 13, 2020 •
edited
Loading

What problem does this PR solve?

fix #556

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test

Release note

  • No release note

@zier-one
Copy link
Contributor Author

/run-kafka-tests

@zier-one zier-one requested a review from amyangfei May 13, 2020 03:35
amyangfei
amyangfei reviewed May 13, 2020
View reviewed changes
Copy link
Contributor

@amyangfei amyangfei left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After this change, the max-message-bytes provided in Kafka sink must be less than 1G ?

amyangfei
amyangfei approved these changes May 13, 2020
View reviewed changes
Copy link
Contributor

@amyangfei amyangfei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amyangfei amyangfei added component/sink Sink component. LGT1 labels May 13, 2020
@zier-one
Copy link
Contributor Author

After this change, the max-message-bytes provided in Kafka sink must be less than 1G ?

Yes, I think it's large enough.

@zier-one zier-one merged commit 99f01ac into pingcap:master May 13, 2020
@zier-one zier-one deleted the fix_race branch May 13, 2020 07:01
5kbpers pushed a commit to 5kbpers/ticdc that referenced this pull request Aug 24, 2020
kafka sink: fix data race in kafka sink (pingcap#565)
ce8dd31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amyangfei amyangfei amyangfei approved these changes

Assignees
No one assigned
Labels
component/sink Sink component.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

data race in kafka sink
2 participants
@zier-one @amyangfei