fb/latency(cdc): add more unit test to agent #5703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
added
release-note-none
overvenus
reviewed
Jun 1, 2022
Co-authored-by: Neil Shen <overvenus@gmail.com>
overvenus
approved these changes
Jun 1, 2022
overvenus
added a commit
to overvenus/ticdc
that referenced
this pull request
Jun 21, 2022
* add more tests. * coverage to 79.1 * Update cdc/scheduler/internal/tp/agent.go Co-authored-by: Neil Shen <overvenus@gmail.com> Co-authored-by: Neil Shen <overvenus@gmail.com>
overvenus
added a commit
to overvenus/ticdc
that referenced
this pull request
Jun 21, 2022
* add more tests. * coverage to 79.1 * Update cdc/scheduler/internal/tp/agent.go Co-authored-by: Neil Shen <overvenus@gmail.com> Co-authored-by: Neil Shen <overvenus@gmail.com>
overvenus
added a commit
to overvenus/ticdc
that referenced
this pull request
Jun 23, 2022
* add more tests. * coverage to 79.1 * Update cdc/scheduler/internal/tp/agent.go Co-authored-by: Neil Shen <overvenus@gmail.com> Co-authored-by: Neil Shen <overvenus@gmail.com>
overvenus
added a commit
to overvenus/ticdc
that referenced
this pull request
Jun 23, 2022
* add more tests. * coverage to 79.1 * Update cdc/scheduler/internal/tp/agent.go Co-authored-by: Neil Shen <overvenus@gmail.com> Co-authored-by: Neil Shen <overvenus@gmail.com>
overvenus
added a commit
to overvenus/ticdc
that referenced
this pull request
Jun 24, 2022
* add more tests. * coverage to 79.1 * Update cdc/scheduler/internal/tp/agent.go Co-authored-by: Neil Shen <overvenus@gmail.com> Co-authored-by: Neil Shen <overvenus@gmail.com>
overvenus
added a commit
to overvenus/ticdc
that referenced
this pull request
Jun 24, 2022
* add more tests. * coverage to 79.1 * Update cdc/scheduler/internal/tp/agent.go Co-authored-by: Neil Shen <overvenus@gmail.com> Co-authored-by: Neil Shen <overvenus@gmail.com>
overvenus
added a commit
to overvenus/ticdc
that referenced
this pull request
Jun 24, 2022
* add more tests. * coverage to 79.1 * Update cdc/scheduler/internal/tp/agent.go Co-authored-by: Neil Shen <overvenus@gmail.com> Co-authored-by: Neil Shen <overvenus@gmail.com>
overvenus
added a commit
to overvenus/ticdc
that referenced
this pull request
Jun 24, 2022
* add more tests. * coverage to 79.1 * Update cdc/scheduler/internal/tp/agent.go Co-authored-by: Neil Shen <overvenus@gmail.com> Co-authored-by: Neil Shen <overvenus@gmail.com>
ti-chi-bot
pushed a commit
that referenced
this pull request
Jun 24, 2022
* add more tests. * coverage to 79.1 * Update cdc/scheduler/internal/tp/agent.go Co-authored-by: Neil Shen <overvenus@gmail.com> Co-authored-by: Neil Shen <overvenus@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #4757
What is changed and how it works?
add more unit test to cover agent implementation.
Check List
Tests
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note