Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: reduce the structure of config file #588

Merged
merged 2 commits into from
May 21, 2020
Merged

Conversation

zier-one
Copy link
Contributor

What problem does this PR solve?

config: reduce the structure of config file

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test

Release note

@zier-one
Copy link
Contributor Author

/run-integration-tests

@zier-one zier-one added the status/ptal Could you please take a look? label May 20, 2020
@codecov-commenter
Copy link

Codecov Report

Merging #588 into master will decrease coverage by 0.0038%.
The diff coverage is 22.7272%.

@@               Coverage Diff                @@
##             master       #588        +/-   ##
================================================
- Coverage   33.7336%   33.7297%   -0.0039%     
================================================
  Files            72         72                
  Lines          7245       7231        -14     
================================================
- Hits           2444       2439         -5     
+ Misses         4623       4614         -9     
  Partials        178        178                

Copy link
Member

@overvenus overvenus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

cmd/changefeed.toml Show resolved Hide resolved
@zier-one zier-one merged commit 85fd7ea into pingcap:master May 21, 2020
@zier-one zier-one deleted the config branch June 8, 2020 03:31
5kbpers pushed a commit to 5kbpers/ticdc that referenced this pull request Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/ptal Could you please take a look?
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants