Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM: Fix some unstable tests (#5507) #5934

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #5507

What problem does this PR solve?

Issue Number:
close #5488
close #5489
close #5490

What is changed and how it works?

  1. change the check statement to be a compatible statement for IT shardddl2/DM-040 optimistic.
  2. wait sync ddl finish for IT shardddl4_1/DM-155 optimistic.
  3. add query-status to wait load finish for IT full_mode/main run.

Check List

Tests

  • Integration test

Release note

None

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. area/dm Issues or PRs related to DM. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-6.0 This PR is cherry-picked to release-6.0 from a source PR. labels Jun 20, 2022
@ti-chi-bot
Copy link
Member Author

@ti-chi-bot: This cherry pick PR is for a release branch and has not yet been approved by release team.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved by the collaborators.

AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 20, 2022
@ti-chi-bot ti-chi-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 21, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jun 21, 2022

Codecov Report

❗ No coverage uploaded for pull request base (release-6.0@2f363f6). Click here to learn what that means.
The diff coverage is n/a.

Flag Coverage Δ
cdc 61.0236% <0.0000%> (?)
dm 51.8292% <0.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             release-6.0      #5934   +/-   ##
================================================
  Coverage               ?   55.9076%           
================================================
  Files                  ?        524           
  Lines                  ?      66905           
  Branches               ?          0           
================================================
  Hits                   ?      37405           
  Misses                 ?      25832           
  Partials               ?       3668           

@WizardXiao
Copy link
Contributor

/run-all-tests

@lance6716
Copy link
Contributor

no need to maintain v6.0

@lance6716 lance6716 closed this Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dm Issues or PRs related to DM. do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-6.0 This PR is cherry-picked to release-6.0 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants