-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sink(ticdc): remove usless ReplicaID field #6197
sink(ticdc): remove usless ReplicaID field #6197
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. @@ Coverage Diff @@
## master #6197 +/- ##
================================================
- Coverage 58.4193% 58.0324% -0.3869%
================================================
Files 711 708 -3
Lines 84205 83374 -831
================================================
- Hits 49192 48384 -808
- Misses 30540 30647 +107
+ Partials 4473 4343 -130 |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 6f53380
|
/run-verify |
What problem does this PR solve?
Issue Number: ref #5928
See: #6109 (comment)
What is changed and how it works?
Remove useless ReplicaID field. We can safely remove it because this default branch.
Check List
Tests
No need, just remove code.
Questions
Will it cause performance regression or break compatibility?
No
Do you need to update user documentation, design documentation or monitoring documentation?
No
Release note