Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sink(ticdc): remove usless ReplicaID field #6197

Merged
merged 1 commit into from
Jul 6, 2022

Conversation

Rustin170506
Copy link
Member

@Rustin170506 Rustin170506 commented Jul 6, 2022

What problem does this PR solve?

Issue Number: ref #5928
See: #6109 (comment)

What is changed and how it works?

Remove useless ReplicaID field. We can safely remove it because this default branch.

Check List

Tests

No need, just remove code.

Questions

Will it cause performance regression or break compatibility?

No

Do you need to update user documentation, design documentation or monitoring documentation?

No

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 6, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • CharlesCheung96
  • overvenus

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 6, 2022
@Rustin170506 Rustin170506 added component/sink Sink component. area/ticdc Issues or PRs related to TiCDC. labels Jul 6, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 6, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 6, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jul 6, 2022

Codecov Report

Merging #6197 (6f53380) into master (ef587e6) will decrease coverage by 0.3868%.
The diff coverage is 62.8132%.

Flag Coverage Δ
cdc 63.8081% <67.6077%> (-0.8766%) ⬇️
dm 51.9504% <49.6350%> (+0.0613%) ⬆️
engine 62.5492% <59.4847%> (+0.0152%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master      #6197        +/-   ##
================================================
- Coverage   58.4193%   58.0324%   -0.3869%     
================================================
  Files           711        708         -3     
  Lines         84205      83374       -831     
================================================
- Hits          49192      48384       -808     
- Misses        30540      30647       +107     
+ Partials       4473       4343       -130     

@Rustin170506
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 6f53380

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 6, 2022
@Rustin170506
Copy link
Member Author

/run-verify

@ti-chi-bot ti-chi-bot merged commit 13264dd into pingcap:master Jul 6, 2022
@Rustin170506 Rustin170506 deleted the rustin-patch-sink-useless branch August 15, 2022 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ticdc Issues or PRs related to TiCDC. component/sink Sink component. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants