Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sinkv2(ticdc): impl mq sink #6288

Merged
merged 16 commits into from
Jul 20, 2022
Merged

sinkv2(ticdc): impl mq sink #6288

merged 16 commits into from
Jul 20, 2022

Conversation

Rustin170506
Copy link
Member

@Rustin170506 Rustin170506 commented Jul 15, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #5928

What is changed and how it works?

impl mq sink.

  • impl mq sink
  • impl mq worker
  • add mock producer
  • add tests for code

Check List

Tests

  • Unit test

Questions

Will it cause performance regression or break compatibility?

No

Do you need to update user documentation, design documentation or monitoring documentation?

No

Release note 

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 15, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • nongfushanquan
  • overvenus

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 15, 2022
@Rustin170506 Rustin170506 marked this pull request as draft July 15, 2022 03:19
@ti-chi-bot ti-chi-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 15, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jul 15, 2022 •
edited
Loading

Codecov Report

Merging #6288 (20e5ece) into master (82defd1) will decrease coverage by 0.0595%.
The diff coverage is 70.5179%.

Flag Coverage Δ
cdc 66.0403% <70.5179%> (-0.1284%) ⬇️
dm 51.9885% <ø> (+0.0479%) ⬆️
engine 63.4827% <ø> (-0.0457%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master      #6288        +/-   ##
================================================
- Coverage   59.2948%   59.2353%   -0.0596%     
================================================
  Files           751        753         +2     
  Lines         86284      85996       -288     
================================================
- Hits          51162      50940       -222     
+ Misses        30598      30552        -46     
+ Partials       4524       4504        -20

@ti-chi-bot ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 15, 2022
@Rustin170506 Rustin170506 marked this pull request as ready for review July 15, 2022 10:50
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 15, 2022
@Rustin170506
Copy link
Member Author

I'll add more tests for kafka_sink.go in next PR to avoid this PR getting too big.

@Rustin170506 Rustin170506 added component/sink Sink component. area/ticdc Issues or PRs related to TiCDC. labels Jul 18, 2022
@Rustin170506 Rustin170506 requested review from overvenus and removed request for sdojjy July 18, 2022 08:33
@Rustin170506 Rustin170506 changed the title sink(ticdc): impl mq sink sinkv2(ticdc): impl mq sink Jul 19, 2022
@asddongmen asddongmen self-requested a review July 19, 2022 09:10
@Rustin170506
Copy link
Member Author

/run-all-tests

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 20, 2022
@Rustin170506 Rustin170506 requested a review from overvenus July 20, 2022 06:20
@Rustin170506 Rustin170506 requested a review from overvenus July 20, 2022 09:34
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 20, 2022
@Rustin170506
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 5135a6b

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 20, 2022
@ti-chi-bot
Copy link
Member

@hi-rustin: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@Rustin170506
Copy link
Member Author

/run-all-tests

@Rustin170506
Copy link
Member Author

/run-dm-integration-test

1 similar comment
@Rustin170506
Copy link
Member Author

/run-dm-integration-test

@ti-chi-bot ti-chi-bot merged commit ca72baf into pingcap:master Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nongfushanquan nongfushanquan nongfushanquan approved these changes

@overvenus overvenus overvenus approved these changes

@hicqu hicqu Awaiting requested review from hicqu

@asddongmen asddongmen Awaiting requested review from asddongmen

Assignees
No one assigned
Labels
area/ticdc Issues or PRs related to TiCDC. component/sink Sink component. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Rustin170506 @ti-chi-bot @codecov-commenter @overvenus @nongfushanquan