Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli (ticdc): fix query changefeed does not contain config info and mask sink uri. #6374

Merged
merged 18 commits into from
Jul 21, 2022
Merged

cli (ticdc): fix query changefeed does not contain config info and mask sink uri. #6374

merged 18 commits into from
Jul 21, 2022

Conversation

asddongmen
Copy link
Contributor

@asddongmen asddongmen commented Jul 20, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: close #6362

What is changed and how it works?

  • cli changefeed query
    image

  • cli changefeed create
    image

  • cli changefeed update
    image

  • cli changefeed remove
    image

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note 

Please refer to [Release Notes Language Style Guide](https://pingcap.github.io/tidb-dev-guide/contribute-to-tidb/release-notes-style-guide.html) to write a quality release note.

If you don't think this PR needs a release note then fill it with `None`.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 20, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • nongfushanquan
  • sdojjy

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 20, 2022
@asddongmen asddongmen changed the title cli (ticdc): fix query changefeed no config info cli (ticdc): fix query changefeed does no contains config info. Jul 20, 2022
@asddongmen asddongmen requested review from sdojjy and crelax July 20, 2022 11:05
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 20, 2022
@asddongmen
Copy link
Contributor Author

/run-integration-tests

sdojjy
sdojjy reviewed Jul 21, 2022
View reviewed changes
cdc/model/http_model.go Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 21, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jul 21, 2022 •
edited
Loading

Codecov Report

Merging #6374 (c8fa818) into master (f14088c) will increase coverage by 0.0768%.
The diff coverage is 79.5698%.

❗ Current head c8fa818 differs from pull request most recent head 129250b. Consider uploading reports for the commit 129250b to get more accurate results

Flag Coverage Δ
cdc 66.0009% <79.5698%> (+0.1075%) ⬆️
dm 52.0258% <ø> (+0.0126%) ⬆️
engine 63.4722% <ø> (+0.0091%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master      #6374        +/-   ##
================================================
+ Coverage   59.2403%   59.3171%   +0.0767%     
================================================
  Files           754        757         +3     
  Lines         86755      87081       +326     
================================================
+ Hits          51394      51654       +260     
- Misses        30799      30851        +52     
- Partials       4562       4576        +14

@asddongmen
Copy link
Contributor Author

/run-integration-tests

@asddongmen asddongmen changed the title cli (ticdc): fix query changefeed does no contains config info. cli (ticdc): fix query changefeed does no contains config info and mask sink uri. Jul 21, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 21, 2022
@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 21, 2022
zhaoxinyu
zhaoxinyu reviewed Jul 21, 2022
View reviewed changes
pkg/util/uri.go Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Jul 21, 2022
@asddongmen
Copy link
Contributor Author

/unhold

@ti-chi-bot ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 21, 2022
@asddongmen
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 65145f8

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 21, 2022
@sdojjy
Copy link
Member

sdojjy commented Jul 21, 2022

/run-integration-tests

@sdojjy
Copy link
Member

sdojjy commented Jul 21, 2022

/run-kafka-integration-test
/run-dm-integration-test

@ti-chi-bot
Copy link
Member

@asddongmen: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@asddongmen
Copy link
Contributor Author

/run-kafka-integration-test

2 similar comments
@asddongmen
Copy link
Contributor Author

/run-kafka-integration-test

@asddongmen
Copy link
Contributor Author

/run-kafka-integration-test

@asddongmen
Copy link
Contributor Author

/run-kafka-integration-tests

@asddongmen
Copy link
Contributor Author

/run-all-tests

@asddongmen
Copy link
Contributor Author

God, please help me to merge this PR.

@asddongmen
Copy link
Contributor Author

/run-kafka-integration-tests

1 similar comment
@asddongmen
Copy link
Contributor Author

/run-kafka-integration-tests

@ti-chi-bot ti-chi-bot merged commit 934824b into pingcap:master Jul 21, 2022
@asddongmen asddongmen mentioned this pull request Jul 22, 2022
Closed
@asddongmen asddongmen deleted the fix_changefeed_cli_query branch September 16, 2022 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhaoxinyu zhaoxinyu zhaoxinyu left review comments

@nongfushanquan nongfushanquan nongfushanquan approved these changes

@sdojjy sdojjy sdojjy approved these changes

@crelax crelax Awaiting requested review from crelax

Assignees
No one assigned
Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

changefeed query has not filter information
6 participants
@asddongmen @ti-chi-bot @codecov-commenter @sdojjy @zhaoxinyu @nongfushanquan