Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sink(ticdc): precheck before split the update event #6403

Merged
merged 7 commits into from
Jul 21, 2022
Merged

sink(ticdc): precheck before split the update event #6403

merged 7 commits into from
Jul 21, 2022

Conversation

Rustin170506
Copy link
Member

@Rustin170506 Rustin170506 commented Jul 21, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: close #6198

What is changed and how it works?

precheck before split the update event. Make sure it will not be nil.

Check List

Tests

Questions

Will it cause performance regression or break compatibility?

No

Do you need to update user documentation, design documentation or monitoring documentation?

No

Release note 

Fix TiCDC panic issue when disable the old value of changefeed

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 21, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • nongfushanquan
  • zhaoxinyu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-triage-completed release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-cherry-pick-release-4.0 Should cherry pick this PR to release-4.0 branch. needs-cherry-pick-release-5.0 Should cherry pick this PR to release-5.0 branch. needs-cherry-pick-release-5.1 Should cherry pick this PR to release-5.1 branch. needs-cherry-pick-release-5.2 Should cherry pick this PR to release-5.2 branch. needs-cherry-pick-release-5.3 Should cherry pick this PR to release-5.3 branch. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.0 Should cherry pick this PR to release-6.0 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.2 Should cherry pick this PR to release-6.2 branch. and removed do-not-merge/needs-triage-completed labels Jul 21, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 21, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 21, 2022
@Rustin170506
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 75b6038

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 21, 2022
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed status/can-merge Indicates a PR has been approved by a committer. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 21, 2022
@Rustin170506
Copy link
Member Author

/run-all-tests

1 similar comment
@Rustin170506
Copy link
Member Author

/run-all-tests

@ti-chi-bot ti-chi-bot merged commit 5d3e4a2 into pingcap:master Jul 21, 2022
@ti-chi-bot ti-chi-bot mentioned this pull request Jul 21, 2022
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #6416.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Jul 21, 2022
@Rustin170506 @ti-chi-bot
This is an automated cherry-pick of pingcap#6403
d143869 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Jul 21, 2022
Closed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #6417.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Jul 21, 2022
@Rustin170506 @ti-chi-bot
This is an automated cherry-pick of pingcap#6403
bfbf6c8 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Jul 21, 2022
Closed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #6418.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Jul 21, 2022
@Rustin170506 @ti-chi-bot
This is an automated cherry-pick of pingcap#6403
bb8fb7e 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Jul 21, 2022
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #6419.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Jul 21, 2022
@Rustin170506 @ti-chi-bot
This is an automated cherry-pick of pingcap#6403
3a24f0d 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Jul 21, 2022
Closed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #6420.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Jul 21, 2022
@Rustin170506 @ti-chi-bot
This is an automated cherry-pick of pingcap#6403
1f69492 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Jul 21, 2022
Closed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #6421.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Jul 21, 2022
@Rustin170506 @ti-chi-bot
This is an automated cherry-pick of pingcap#6403
bb9ffa9 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Jul 21, 2022
Closed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #6422.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Jul 21, 2022
@Rustin170506 @ti-chi-bot
This is an automated cherry-pick of pingcap#6403
37cce24 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Jul 21, 2022
Closed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #6423.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: cannot checkout release-6.2: error checking out release-6.2: exit status 1. output: error: pathspec 'release-6.2' did not match any file(s) known to git

@Rustin170506 Rustin170506 deleted the rustin-patch-split branch July 21, 2022 12:33
ti-chi-bot added a commit that referenced this pull request Aug 17, 2022
@ti-chi-bot
sink(ticdc): precheck before split the update event (#6403) (#6416)
5e2fdba 
close #6198
ti-chi-bot added a commit that referenced this pull request Sep 8, 2022
@ti-chi-bot
sink(ticdc): precheck before split the update event (#6403) (#6419)
4a47f46 
close #6198
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nongfushanquan nongfushanquan nongfushanquan approved these changes

@zhaoxinyu zhaoxinyu zhaoxinyu approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-4.0 Should cherry pick this PR to release-4.0 branch. needs-cherry-pick-release-5.0 Should cherry pick this PR to release-5.0 branch. needs-cherry-pick-release-5.1 Should cherry pick this PR to release-5.1 branch. needs-cherry-pick-release-5.2 Should cherry pick this PR to release-5.2 branch. needs-cherry-pick-release-5.3 Should cherry pick this PR to release-5.3 branch. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.0 Should cherry pick this PR to release-6.0 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.2 Should cherry pick this PR to release-6.2 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TiCDC panicked when handling update events with enable-old-value=false
4 participants
@Rustin170506 @ti-chi-bot @zhaoxinyu @nongfushanquan