Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

precheck(dm): fix MySQL 8.0 SHOW GRANTS with role #6485

Merged
merged 22 commits into from
Aug 2, 2022
Merged

precheck(dm): fix MySQL 8.0 SHOW GRANTS with role #6485

merged 22 commits into from
Aug 2, 2022

Conversation

lance6716
Copy link
Contributor

@lance6716 lance6716 commented Jul 27, 2022 •
edited
Loading

Signed-off-by: lance6716 lance6716@gmail.com

What problem does this PR solve?

Issue Number: close #6448 close #6506

What is changed and how it works?

introduce pingcap/tidb#36565 to fix the issue , and also pingcap/tidb#36576 by the way

Check List

Tests

  • Integration test

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note 

Improve compatibility for MySQL 8.0 upstream

@lance6716
precheck(dm): fix MySQL 8.0 SHOW GRANTS with role
9c41687 
Signed-off-by: lance6716 <lance6716@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 27, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • buchuitoudegou
  • lichunzhu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/needs-triage-completed labels Jul 27, 2022
@lance6716

This comment was marked as resolved.

Sign in to view
@ti-chi-bot ti-chi-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 27, 2022
@lance6716 lance6716 added the area/dm Issues or PRs related to DM. label Jul 27, 2022
@lance6716
Copy link
Contributor Author

/check-issue-triage-complete

@lance6716
remove replace
b5d08ad 
Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716 lance6716 changed the title [WIP] precheck(dm): fix MySQL 8.0 SHOW GRANTS with role precheck(dm): fix MySQL 8.0 SHOW GRANTS with role Jul 27, 2022
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 27, 2022
@lance6716
Copy link
Contributor Author

/cc @GMHDBJD @D3Hunter @buchuitoudegou

@lance6716
fix UT
8df9068 
Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716
Copy link
Contributor Author

/run-all-tests

@lance6716
change impl
6ff33aa 
Signed-off-by: lance6716 <lance6716@gmail.com>
lichunzhu
lichunzhu approved these changes Jul 27, 2022
View reviewed changes
Copy link
Contributor

@lichunzhu lichunzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 27, 2022
@lance6716
another fix
3ae4864 
Signed-off-by: lance6716 <lance6716@gmail.com>
@GMHDBJD GMHDBJD added the area/ticdc Issues or PRs related to TiCDC. label Jul 27, 2022
@lance6716
fix another CI
9dc3e7a 
Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716
fix UT
3965cf0 
Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716
Copy link
Contributor Author

/run-verify

@lance6716
Copy link
Contributor Author

/cc @liuzix @hi-rustin some CDC schema storage snapshot behaviour is changed, please review

buchuitoudegou
buchuitoudegou approved these changes Jul 28, 2022
View reviewed changes
Copy link
Contributor

@buchuitoudegou buchuitoudegou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. But I don't really understand the changes under cdc/entry. Do they also relate to the compatibility issue of DM?

@ti-chi-bot ti-chi-bot removed the status/LGT1 Indicates that a PR has LGTM 1. label Jul 28, 2022
@lance6716
Copy link
Contributor Author

/run-dm-integration-test

@lance6716
Copy link
Contributor Author

https://ci2.pingcap.net/blue/organizations/jenkins/dm_ghpr_integration_test/detail/dm_ghpr_integration_test/8452/pipeline/204/

CI passed

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 5a50980

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 1, 2022
@lance6716
Copy link
Contributor Author

/run-verify

@lance6716
Copy link
Contributor Author

/run-dm-integration-test
/run-kafka-integration-test
/run-verify

@lance6716
Copy link
Contributor Author

/hold

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 1, 2022
@lance6716
Copy link
Contributor Author

source bound is not stable，will update it later

@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Aug 1, 2022
@lance6716
Copy link
Contributor Author

/unhold

/merge

@ti-chi-bot ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 1, 2022
@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: f8dd73a

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 1, 2022
@lance6716
Copy link
Contributor Author

/run-all-tests

@lance6716
Copy link
Contributor Author

/run-dm-integration-test
/run-verify

@lance6716
Copy link
Contributor Author

lance6716 commented Aug 1, 2022 •
edited
Loading

/hold

https://ci2.pingcap.net/blue/organizations/jenkins/dm_ghpr_integration_test/detail/dm_ghpr_integration_test/8458/pipeline

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 1, 2022
@lance6716
Copy link
Contributor Author

/unhold
/merge

@ti-chi-bot ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 2, 2022
@ti-chi-bot
Copy link
Member

@lance6716: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@lance6716
Copy link
Contributor Author

/run-leak-test
/run-verify

@lance6716
Copy link
Contributor Author

/run-verify

@lance6716
Copy link
Contributor Author

/run-kafka-integration-test

1 similar comment
@lance6716
Copy link
Contributor Author

/run-kafka-integration-test

@ti-chi-bot ti-chi-bot merged commit f34c680 into pingcap:master Aug 2, 2022
@lance6716 lance6716 deleted the fix-8.0-grant branch November 10, 2022 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rustin170506 Rustin170506 Rustin170506 left review comments

@liuzix liuzix liuzix left review comments

@nongfushanquan nongfushanquan nongfushanquan approved these changes

@buchuitoudegou buchuitoudegou buchuitoudegou approved these changes

@lichunzhu lichunzhu lichunzhu approved these changes

@D3Hunter D3Hunter Awaiting requested review from D3Hunter

@GMHDBJD GMHDBJD Awaiting requested review from GMHDBJD

Assignees
No one assigned
Labels
area/dm Issues or PRs related to DM. area/ticdc Issues or PRs related to TiCDC. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
10 participants
@lance6716 @ti-chi-bot @overvenus @codecov-commenter @liuzix @lichunzhu @buchuitoudegou @Rustin170506 @nongfushanquan @GMHDBJD