Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(dm): fix upstream switch CI and reduce versions in upgrading CI #6502

Merged
merged 11 commits into from
Aug 3, 2022
Merged

test(dm): fix upstream switch CI and reduce versions in upgrading CI #6502

merged 11 commits into from
Aug 3, 2022

Conversation

lance6716
Copy link
Contributor

@lance6716 lance6716 commented Jul 28, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #4159

What is changed and how it works?

  • during the upstream switch CI down because docker image change for 23 days, we somehow break this CI.
  • reduce versions in upgrading test

Check List

Tests

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note 

`None`.

@lance6716
actions(dm): fix default MySQL image changed to CentOS based
7ab4ed5 
Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716
reduce upgrading version
ec61a97 
Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716
test(dm): fix relay suffix is not written to syncerBinlog
f14f2dd 
Signed-off-by: lance6716 <lance6716@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 28, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • GMHDBJD
  • buchuitoudegou

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed do-not-merge/needs-linked-issue labels Jul 28, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jul 28, 2022 •
edited
Loading

Codecov Report

Merging #6502 (eb7be23) into master (6290709) will decrease coverage by 0.0842%.
The diff coverage is 59.2045%.

Flag Coverage Δ
cdc 65.9290% <62.7608%> (-0.1840%) ⬇️
dm 52.0548% <54.4117%> (+0.0185%) ⬆️
engine 63.4390% <46.2809%> (-0.3027%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master      #6502        +/-   ##
================================================
- Coverage   59.4214%   59.3371%   -0.0843%     
================================================
  Files           763        775        +12     
  Lines         87418      88014       +596     
================================================
+ Hits          51945      52225       +280     
- Misses        30894      31170       +276     
- Partials       4579       4619        +40

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jul 28, 2022
@lance6716 lance6716 changed the title [WIP]Fix actions 3 test(dm): fix upstream switch CI and reduce versions in upgrading CI Jul 28, 2022
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 28, 2022
@lance6716 lance6716 added the area/dm Issues or PRs related to DM. label Jul 28, 2022
@lance6716
Copy link
Contributor Author

/cc @GMHDBJD

@ti-chi-bot ti-chi-bot requested a review from GMHDBJD July 28, 2022 07:57
@lance6716
Copy link
Contributor Author

/cc @GMHDBJD @buchuitoudegou

@lance6716
Copy link
Contributor Author

ping @buchuitoudegou @GMHDBJD

GMHDBJD
GMHDBJD approved these changes Aug 2, 2022
View reviewed changes
Copy link
Contributor

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 2, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 2, 2022
@lance6716
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 741c2e6

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 2, 2022
@lance6716
Copy link
Contributor Author

/run-all-tests

@lance6716
Copy link
Contributor Author

/run-kafka-integration-test
/run-verify

@lance6716
Copy link
Contributor Author

/run-dm-integration-test

@lance6716
Copy link
Contributor Author

/run-dm-integration-test
/run-kafka-integration-test

2 similar comments
@lance6716
Copy link
Contributor Author

/run-dm-integration-test
/run-kafka-integration-test

@lance6716
Copy link
Contributor Author

/run-dm-integration-test
/run-kafka-integration-test

@lance6716
Copy link
Contributor Author

/run-dm-integration-test

@ti-chi-bot
Copy link
Member

@lance6716: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@lance6716
Copy link
Contributor Author

/run-dm-integration-test

@ti-chi-bot ti-chi-bot merged commit 16ca2e3 into pingcap:master Aug 3, 2022
@lance6716 lance6716 deleted the fix-actions-3 branch November 10, 2022 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GMHDBJD GMHDBJD GMHDBJD approved these changes

@buchuitoudegou buchuitoudegou buchuitoudegou approved these changes

Assignees
No one assigned
Labels
area/dm Issues or PRs related to DM. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lance6716 @ti-chi-bot @codecov-commenter @buchuitoudegou @GMHDBJD