Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(dm): fix using pgrep to check argument pattern #6572

Merged
merged 17 commits into from
Aug 3, 2022

Conversation

lance6716
Copy link
Contributor

@lance6716 lance6716 commented Aug 2, 2022

Signed-off-by: lance6716 lance6716@gmail.com

What problem does this PR solve?

Issue Number: close #6526, close #5731, close #5287

What is changed and how it works?

  • we use kill_process dm-worker1 in test script, and finally it will become pgrep dm-worker1. This is not right because dm-worker1 is in arguments and pgrep only check process name.
  • old problems, same root cause but different case as flaking test ALTER TABLE shardddl.tb ADD COLUMN new_col1 INT DEFAULT -1 #5807
  • after syncer processes RowsEvent, check_sync_diff will pass, but XIDEvent may have not been written to relay log. We retry checking for 5 seconds.

Check List

Tests

  • Integration test
  • Manual test (add detailed scripts or steps below)
# lance @ lance6716-nuc10i7fnh in ~/go/src/github.com/pingcap/tiflow on git:master o [14:31:49] 
$ pgrep -f dm-worker1     
467807

# lance @ lance6716-nuc10i7fnh in ~/go/src/github.com/pingcap/tiflow on git:master x [14:32:09] 
$ pgrep dm-worker1                                       

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

 `None`.

Signed-off-by: lance6716 <lance6716@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 2, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • D3Hunter
  • GMHDBJD

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/needs-triage-completed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 2, 2022
@lance6716
Copy link
Contributor Author

/cc @GMHDBJD @buchuitoudegou @D3Hunter

@lance6716
Copy link
Contributor Author

/check-issue-triage-complete

@ti-chi-bot ti-chi-bot added needs-cherry-pick-release-5.3 Should cherry pick this PR to release-5.3 branch. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.2 Should cherry pick this PR to release-6.2 branch. and removed do-not-merge/needs-triage-completed labels Aug 2, 2022
@lance6716
Copy link
Contributor Author

/run-verify

@lance6716
Copy link
Contributor Author

/run-dm-integration-test

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Aug 2, 2022
Copy link
Contributor

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 2, 2022
@lance6716
Copy link
Contributor Author

/hold

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 2, 2022
Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716
Copy link
Contributor Author

/run-dm-integration-test

@lance6716
Copy link
Contributor Author

/unhold

@ti-chi-bot ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 2, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 2, 2022
@lance6716
Copy link
Contributor Author

/run-dm-integration-test

Signed-off-by: lance6716 <lance6716@gmail.com>
Signed-off-by: lance6716 <lance6716@gmail.com>
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed status/can-merge Indicates a PR has been approved by a committer. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 3, 2022
@lance6716
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: e98b946

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 3, 2022
@lance6716
Copy link
Contributor Author

/run-dm-integration-test

@ti-chi-bot
Copy link
Member

@lance6716: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@lance6716
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot merged commit b2da15f into pingcap:master Aug 3, 2022
ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Aug 3, 2022
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #6584.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Aug 3, 2022
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #6585.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Aug 3, 2022
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #6586.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #6587.

ti-chi-bot added a commit that referenced this pull request Aug 4, 2022
ti-chi-bot added a commit that referenced this pull request Aug 5, 2022
ti-chi-bot added a commit that referenced this pull request Aug 8, 2022
@lance6716 lance6716 deleted the fix-pgrep branch November 10, 2022 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-5.3 Should cherry pick this PR to release-5.3 branch. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.2 Should cherry pick this PR to release-6.2 branch. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
6 participants