-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(dm): fix using pgrep to check argument pattern #6572
Conversation
Signed-off-by: lance6716 <lance6716@gmail.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/check-issue-triage-complete |
/run-verify |
/run-dm-integration-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/hold |
Signed-off-by: lance6716 <lance6716@gmail.com>
/run-dm-integration-test |
/unhold |
/run-dm-integration-test |
Signed-off-by: lance6716 <lance6716@gmail.com>
Signed-off-by: lance6716 <lance6716@gmail.com>
/merge |
This pull request has been accepted and is ready to merge. Commit hash: e98b946
|
/run-dm-integration-test |
@lance6716: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/run-all-tests |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
In response to a cherrypick label: new pull request created: #6584. |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
In response to a cherrypick label: new pull request created: #6585. |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
In response to a cherrypick label: new pull request created: #6586. |
In response to a cherrypick label: new pull request created: #6587. |
Signed-off-by: lance6716 lance6716@gmail.com
What problem does this PR solve?
Issue Number: close #6526, close #5731, close #5287
What is changed and how it works?
kill_process dm-worker1
in test script, and finally it will becomepgrep dm-worker1
. This is not right becausedm-worker1
is in arguments andpgrep
only check process name.shardddl
.tb
ADD COLUMNnew_col1
INT DEFAULT -1 #5807Check List
Tests
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note