test(dm): inject error to a not-auto-resume source #6624
Conversation
Signed-off-by: lance6716 <lance6716@gmail.com>
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
added
needs-cherry-pick-release-5.3
ti-chi-bot
added
the
size/S
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. @@ Coverage Diff @@
## master #6624 +/- ##
================================================
- Coverage 59.4214% 59.2028% -0.2186%
================================================
Files 763 780 +17
Lines 87418 88418 +1000
================================================
+ Hits 51945 52346 +401
- Misses 30894 31429 +535
- Partials 4579 4643 +64 |
| @@ -308,7 +308,7 @@ function DM_DROP_COLUMN_EXEC_ERROR() { | |||
| function DM_DROP_COLUMN_ALL_DONE_CASE() { | |||
| # get worker of source1 | |||
| w="1" | |||
| got=$(grep -a "mysql-replica-01" $WORK_DIR/worker1/log/dm-worker.log | wc -l) | |||
| got=$(grep -a "mysql-replica-02" $WORK_DIR/worker1/log/dm-worker.log | wc -l) | |||
There was a problem hiding this comment.
If worker1 doesn't contain "mysql-replica-02" (which might potentially mean it contains "mysql-replica-01") then w="2"? I assume the previous code is more compatible with the comment above, "get worker of souce1".😵
|
/cc @lichunzhu |
|
@buchuitoudegou Sorry I errorly choose |
|
/merge |
1 similar comment
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: 5f6be53
|
1 similar comment
|
This pull request has been accepted and is ready to merge. Commit hash: 5f6be53
|
ti-chi-bot
added
the
status/can-merge
|
@lance6716: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
|
In response to a cherrypick label: new pull request created: #6655. |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
|
In response to a cherrypick label: new pull request created: #6656. |
|
In response to a cherrypick label: new pull request created: #6657. |
|
In response to a cherrypick label: new pull request created: #6658. |
Signed-off-by: lance6716 lance6716@gmail.com
What problem does this PR solve?
Issue Number: close #6618
What is changed and how it works?
mysql-replica-2 has turned off auto-resume, we use its worker to inject failpoint
Check List
Tests
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note