Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support to balance subtasks to new captures #665

Merged
merged 2 commits into from
Jun 19, 2020
Merged

support to balance subtasks to new captures #665

merged 2 commits into from
Jun 19, 2020

Conversation

zier-one
Copy link
Contributor

@zier-one zier-one commented Jun 16, 2020 •
edited
Loading

What problem does this PR solve?

support to balance subtasks to new captures ,fix #638

What is changed and how it works?

  • Adjust the default value of Scheduler.PollingTime to -1
  • If Scheduler.PollingTime is less than 0, the rebanlance process will not be call by time trigger.

Check List

Tests

  • Unit test
  • Integration test

Release note

  • support to balance subtasks to new captures

@zier-one zier-one added component/scheduler TiCDC inner scheduler component. enhancement labels Jun 16, 2020
@zier-one
Copy link
Contributor Author

/run-integration-tests

@amyangfei amyangfei added this to the v4.0.2 milestone Jun 17, 2020
@amyangfei amyangfei added the release-blocker This issue blocks a release. Please solve it ASAP. label Jun 17, 2020
overvenus
overvenus approved these changes Jun 17, 2020
View reviewed changes
Copy link
Member

@overvenus overvenus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zier-one
Copy link
Contributor Author

/run-integration-tests

@CLAassistant
Copy link

CLAassistant commented Jun 19, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@zier-one zier-one removed the WIP label Jun 19, 2020
amyangfei
amyangfei approved these changes Jun 19, 2020
View reviewed changes
Copy link
Contributor

@amyangfei amyangfei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amyangfei amyangfei added LGT2 and removed LGT1 labels Jun 19, 2020
@overvenus
Copy link
Member

/merge

@overvenus
Copy link
Member

/run-integration-tests

1 similar comment
@zier-one
Copy link
Contributor Author

/run-integration-tests

@zier-one
Copy link
Contributor Author

/run-integration-tests

@codecov-commenter
Copy link

Codecov Report

Merging #665 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master       #665   +/-   ##
===========================================
  Coverage   32.5249%   32.5249%           
===========================================
  Files            88         88           
  Lines          8824       8824           
===========================================
  Hits           2870       2870           
  Misses         5721       5721           
  Partials        233        233

@amyangfei amyangfei merged commit b16b62e into pingcap:master Jun 19, 2020
@zier-one zier-one deleted the diaodu branch July 2, 2020 07:57
5kbpers pushed a commit to 5kbpers/ticdc that referenced this pull request Aug 24, 2020
support to balance subtasks to new captures (pingcap#665)
f1a9bc0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@overvenus overvenus overvenus approved these changes

@amyangfei amyangfei amyangfei approved these changes

Assignees
No one assigned
Labels
component/scheduler TiCDC inner scheduler component. release-blocker This issue blocks a release. Please solve it ASAP.
Projects
None yet
Milestone
v4.0.2
Development

Successfully merging this pull request may close these issues.

Changefeed subtasks can not be balanced to new captures
5 participants
@zier-one @CLAassistant @overvenus @codecov-commenter @amyangfei