-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sink(ticdc): remove pulsar sink #6983
sink(ticdc): remove pulsar sink #6983
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/hold PLEASE DO NOT MERGE THIS PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Self check
Codecov Report
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. @@ Coverage Diff @@
## master #6983 +/- ##
================================================
- Coverage 59.8253% 59.8180% -0.0073%
================================================
Files 791 787 -4
Lines 90221 90242 +21
================================================
+ Hits 53975 53981 +6
- Misses 31498 31512 +14
- Partials 4748 4749 +1 |
/unhold |
LGTM |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: efddb1e
|
@hi-rustin: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
Issue Number: close #7087
What is changed and how it works?
remove pulsar sink.
Check List
Tests
Questions
Will it cause performance regression or break compatibility?
No
Do you need to update user documentation, design documentation or monitoring documentation?
See: pingcap/docs-cn#11112
Release note