pkg/pdutil(ticdc): improve pd time accuracy #7024
Conversation
Signed-off-by: Neil Shen <overvenus@gmail.com>
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
added
release-note-none
|
please fix the failed test cases. |
| return cacheTime, errors.Trace(err) | ||
| defer c.mu.RUnlock() | ||
| tsEventTime := c.mu.tsEventTime | ||
| current := tsEventTime.Add(time.Since(c.mu.tsProcessingTime)) |
There was a problem hiding this comment.
why can we just return tsEventTime.Add(time.Since(c.mu.tsProcessingTime))?
There was a problem hiding this comment.
To make code easier to understand
Signed-off-by: Neil Shen <overvenus@gmail.com>
overvenus
force-pushed
the
accurate-pd-time
branch
from
1a3f066
to
d8c4c61
Compare
ti-chi-bot
added
status/LGT2
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: d8c4c61
|
ti-chi-bot
added
the
status/can-merge
|
@overvenus: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
| return ret, nil | ||
| } | ||
|
|
||
| // Run will get time from pd periodically to cache in timeCache | ||
| // Run gets time from pd periodically. | ||
| func (c *clock) Run(ctx context.Context) { | ||
| ctx, cancel := context.WithCancel(ctx) | ||
| c.cancel = cancel |
There was a problem hiding this comment.
cancel is called by stop, cause race detected in the test.
ti-chi-bot
removed
the
status/can-merge
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: 159c546
|
ti-chi-bot
added
the
status/can-merge
Codecov Report
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. @@ Coverage Diff @@
## master #7024 +/- ##
================================================
+ Coverage 59.8253% 59.8700% +0.0447%
================================================
Files 791 792 +1
Lines 90221 90648 +427
================================================
+ Hits 53975 54271 +296
- Misses 31498 31616 +118
- Partials 4748 4761 +13 |
|
/run-all-tests |
| } | ||
|
|
||
| // Stop clock. | ||
| func (c *clock) Stop() { | ||
| c.mu.Lock() | ||
| defer c.mu.Unlock() | ||
| c.cancel() |
There was a problem hiding this comment.
it looks that the cancel maybe nil?
|
/run-verify-ci |
What problem does this PR solve?
Issue Number: ref #4757
What is changed and how it works?
Add duration to ts event time.
Check List
Tests
Questions
Will it cause performance regression or break compatibility?
No.
Do you need to update user documentation, design documentation or monitoring documentation?
No.
Release note