Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(dm): fix upstream_switch GitHub actions #7063

Merged
merged 5 commits into from
Sep 15, 2022

Conversation

lance6716
Copy link
Contributor

@lance6716 lance6716 commented Sep 14, 2022

Signed-off-by: lance6716 lance6716@gmail.com

What problem does this PR solve?

Issue Number: ref #4159

What is changed and how it works?

Check List

Tests

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

`None`.

Signed-off-by: lance6716 <lance6716@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 14, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • buchuitoudegou
  • okJiang

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 14, 2022
@lance6716
Copy link
Contributor Author

/cc @GMHDBJD @buchuitoudegou

@lance6716
Copy link
Contributor Author

/cc @GMHDBJD @D3Hunter @buchuitoudegou

@ti-chi-bot ti-chi-bot requested a review from D3Hunter September 15, 2022 02:20
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 15, 2022
@lance6716
Copy link
Contributor Author

ping @GMHDBJD @okJiang

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 15, 2022
@lance6716
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 8ac328f

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 15, 2022
@codecov-commenter
Copy link

codecov-commenter commented Sep 15, 2022

Codecov Report

Merging #7063 (9776807) into master (0c9804b) will increase coverage by 0.3526%.
The diff coverage is 25.0000%.

Additional details and impacted files
Flag Coverage Δ
cdc 67.2675% <100.0000%> (+0.1345%) ⬆️
dm 51.8147% <16.6666%> (-0.0278%) ⬇️
engine 62.7777% <ø> (+2.2345%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master      #7063        +/-   ##
================================================
+ Coverage   59.5332%   59.8859%   +0.3526%     
================================================
  Files           796        793         -3     
  Lines         91317      90801       -516     
================================================
+ Hits          54364      54377        +13     
+ Misses        32180      31664       -516     
+ Partials       4773       4760        -13     

@lance6716
Copy link
Contributor Author

/run-engine-integration-test

@ti-chi-bot
Copy link
Member

@lance6716: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@amyangfei
Copy link
Contributor

/merge

@ti-chi-bot ti-chi-bot merged commit 2763310 into pingcap:master Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants