Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(DM): add check log contain to safe-mode integration test (#7152) #7163

Merged
merged 4 commits into from
Sep 21, 2022
Merged

test(DM): add check log contain to safe-mode integration test (#7152) #7163

merged 4 commits into from
Sep 21, 2022

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #7152

What problem does this PR solve?

Issue Number: ref #4159, close #7099

What is changed and how it works?

  • the worker1 didn't enter sync status and execute dml, after check_diff before kill_worker, so its SafeModeExitPoint is yet same as its GlobalCheckpoint(beginPosition). This is the unstable reason.

Check List

Tests

  • Integration test

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note 

`None`

@ti-chi-bot ti-chi-bot mentioned this pull request Sep 21, 2022
Merged
@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added area/dm Issues or PRs related to DM. do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-6.3 This PR is cherry-picked to release-6.3 from a source PR. labels Sep 21, 2022
@okJiang
Copy link
Member

okJiang commented Sep 21, 2022

/run-all-test

@okJiang
Copy link
Member

okJiang commented Sep 21, 2022

/run-all-tests

@sre-bot sre-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Sep 21, 2022
@okJiang
Copy link
Member

okJiang commented Sep 21, 2022

/run-dm-integration-test
/run-unit-test

@okJiang
Copy link
Member

okJiang commented Sep 21, 2022

/run-verify

@asddongmen
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: a71f03b

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 21, 2022
@okJiang
Copy link
Member

okJiang commented Sep 21, 2022

/run-verify
/run-unit-test

2 similar comments
@okJiang
Copy link
Member

okJiang commented Sep 21, 2022

/run-verify
/run-unit-test

@okJiang
Copy link
Member

okJiang commented Sep 21, 2022

/run-verify
/run-unit-test

@ti-chi-bot ti-chi-bot merged commit 6bee35a into pingcap:release-6.3 Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@okJiang okJiang

Labels
area/dm Issues or PRs related to DM. cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-6.3 This PR is cherry-picked to release-6.3 from a source PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ti-chi-bot @okJiang @asddongmen @sre-bot