-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sinkv2(cdc): add more sinkv2 txn sink metrics #7214
sinkv2(cdc): add more sinkv2 txn sink metrics #7214
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Signed-off-by: qupeng <qupeng@pingcap.com>
Codecov Report
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. @@ Coverage Diff @@
## master #7214 +/- ##
================================================
- Coverage 59.6043% 59.5594% -0.0449%
================================================
Files 790 790
Lines 91089 90753 -336
================================================
- Hits 54293 54052 -241
+ Misses 32051 31974 -77
+ Partials 4745 4727 -18 |
/cc |
3945349
to
44240ed
Compare
Signed-off-by: qupeng <qupeng@pingcap.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
It looks the |
For each panel, please also enable |
I prefer to keep |
Signed-off-by: qupeng <qupeng@pingcap.com>
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 02804c2
|
Signed-off-by: qupeng qupeng@pingcap.com
What problem does this PR solve?
Issue Number: ref #5928
What is changed and how it works?
Add more metric panels for transaction sink.
Check List
Tests
An example can be found here.
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note