Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sinkv2(cdc): add more sinkv2 txn sink metrics #7214

Merged
merged 7 commits into from
Sep 27, 2022

Conversation

hicqu
Copy link
Contributor

@hicqu hicqu commented Sep 26, 2022

Signed-off-by: qupeng qupeng@pingcap.com

What problem does this PR solve?

Issue Number: ref #5928

What is changed and how it works?

Add more metric panels for transaction sink.

Check List

Tests

  • No code

An example can be found here.

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 26, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • 3AceShowHand
  • hi-rustin

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 26, 2022
@hicqu hicqu changed the title add more sinkv2 txn sink metrics sinkv2(cdc): add more sinkv2 txn sink metrics Sep 26, 2022
Signed-off-by: qupeng <qupeng@pingcap.com>
@codecov-commenter
Copy link

codecov-commenter commented Sep 26, 2022

Codecov Report

Merging #7214 (6e88751) into master (d8fff7a) will decrease coverage by 0.0448%.
The diff coverage is 72.8813%.

Additional details and impacted files
Flag Coverage Δ
cdc 67.1772% <79.4520%> (-0.0383%) ⬇️
dm 51.6560% <ø> (-0.1815%) ⬇️
engine 60.9490% <70.7207%> (+0.0909%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master      #7214        +/-   ##
================================================
- Coverage   59.6043%   59.5594%   -0.0449%     
================================================
  Files           790        790                
  Lines         91089      90753       -336     
================================================
- Hits          54293      54052       -241     
+ Misses        32051      31974        -77     
+ Partials       4745       4727        -18     

@Rustin170506
Copy link
Member

/cc

Copy link
Member

@Rustin170506 Rustin170506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 27, 2022
@3AceShowHand
Copy link
Contributor

It looks the Output Row Count (per second) is identical to the MySQL sink write rows count/s and Kafka sink write rows count/s, how about renaming it to sink write rows count/s.

@3AceShowHand
Copy link
Contributor

For each panel, please also enable legend/values options, at least current.

@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 27, 2022
@hicqu
Copy link
Contributor Author

hicqu commented Sep 27, 2022

I prefer to keep Output Row Count (per second). Seems it's clear enough.

Signed-off-by: qupeng <qupeng@pingcap.com>
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 27, 2022
@Rustin170506
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 02804c2

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 27, 2022
@ti-chi-bot ti-chi-bot merged commit 2c12e2e into pingcap:master Sep 27, 2022
@hicqu hicqu deleted the sinkv2-more-txn-sink-metrics branch September 27, 2022 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants