-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sink(ticdc): Use TableInfo
instead of SimpleTableInfo
to hold more information in DDLEvent
#7221
sink(ticdc): Use TableInfo
instead of SimpleTableInfo
to hold more information in DDLEvent
#7221
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/cc @asddongmen |
TableInfo
in DDLEvent
instead of SimpleTableInfo
to obtain more information TableInfo
instead of SimpleTableInfo
to hold more information in DDLEvent
/run-all-tests |
/run-all-tests |
/run-all-tests |
/run-all-tests |
Codecov Report
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. @@ Coverage Diff @@
## master #7221 +/- ##
================================================
+ Coverage 59.7265% 59.8563% +0.1297%
================================================
Files 790 789 -1
Lines 91204 90744 -460
================================================
- Hits 54473 54316 -157
+ Misses 31987 31706 -281
+ Partials 4744 4722 -22 |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 36b7024
|
@zhaoxinyu: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/run-kafka-integration-test |
What problem does this PR solve?
Issue Number: ref #6797
What is changed and how it works?
Since table definition (i.e. column type, column length, column precision, etc) and table version are needed when dispatching DDL events to cloud storage sink, we have to expand
DDLEvent
to contain these information. At present,TableInfo
incdc/model/schema_storage.go
is well enough to provide such information, so it is used to replaceSimpleTableInfo
inDDLEvent
.Check List
Tests
Questions
Will it cause performance regression or break compatibility?
No
Do you need to update user documentation, design documentation or monitoring documentation?
No
Release note