Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sink(ticdc): Use TableInfo instead of SimpleTableInfo to hold more information in DDLEvent #7221

Merged
merged 15 commits into from
Oct 10, 2022

Conversation

zhaoxinyu
Copy link
Contributor

What problem does this PR solve?

Issue Number: ref #6797

What is changed and how it works?

Since table definition (i.e. column type, column length, column precision, etc) and table version are needed when dispatching DDL events to cloud storage sink, we have to expand DDLEvent to contain these information. At present, TableInfo in cdc/model/schema_storage.go is well enough to provide such information, so it is used to replace SimpleTableInfo in DDLEvent.

Check List

Tests

  • Unit test
  • Integration test

Questions

Will it cause performance regression or break compatibility?

No

Do you need to update user documentation, design documentation or monitoring documentation?

No

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 26, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • asddongmen
  • hi-rustin

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Sep 26, 2022
@ti-chi-bot ti-chi-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Sep 26, 2022
@zhaoxinyu
Copy link
Contributor Author

/cc @asddongmen
/cc @hi-rustin
/cc @3AceShowHand
/cc @nongfushanquan

@zhaoxinyu zhaoxinyu changed the title sink(ticdc): Use TableInfo in DDLEvent instead of SimpleTableInfo to obtain more information sink(ticdc): Use TableInfo instead of SimpleTableInfo to hold more information in DDLEvent Sep 26, 2022
@zhaoxinyu
Copy link
Contributor Author

/run-all-tests

@zhaoxinyu
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 27, 2022
@zhaoxinyu
Copy link
Contributor Author

/run-all-tests

@zhaoxinyu
Copy link
Contributor Author

/run-all-tests

@codecov-commenter
Copy link

codecov-commenter commented Oct 9, 2022

Codecov Report

Merging #7221 (36b7024) into master (8f81dbb) will increase coverage by 0.1297%.
The diff coverage is 42.7184%.

Additional details and impacted files
Flag Coverage Δ
cdc 67.7108% <41.9087%> (+0.3967%) ⬆️
dm 51.9553% <26.9230%> (+0.0013%) ⬆️
engine 61.0728% <57.1428%> (-0.0001%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master      #7221        +/-   ##
================================================
+ Coverage   59.7265%   59.8563%   +0.1297%     
================================================
  Files           790        789         -1     
  Lines         91204      90744       -460     
================================================
- Hits          54473      54316       -157     
+ Misses        31987      31706       -281     
+ Partials       4744       4722        -22     

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 10, 2022
@Rustin170506
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 36b7024

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 10, 2022
@ti-chi-bot
Copy link
Member

@zhaoxinyu: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@zhaoxinyu
Copy link
Contributor Author

/run-kafka-integration-test

@ti-chi-bot ti-chi-bot merged commit eb03362 into pingcap:master Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants