Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sinkv2(ticdc): add mq worker flush duration metric #7263

Merged

Conversation

Rustin170506
Copy link
Member

@Rustin170506 Rustin170506 commented Sep 29, 2022

What problem does this PR solve?

Issue Number: ref #5928

What is changed and how it works?

add mq worker flush duration metric.

Check List

Tests

Please check out http://10.2.6.161:3000/d/YiGL8hBZ16546546/test-cluster-ticdc54354353?orgId=1&refresh=1m

image

Questions

Will it cause performance regression or break compatibility?

No

Do you need to update user documentation, design documentation or monitoring documentation?

No

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 29, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hicqu
  • nongfushanquan

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 29, 2022
@Rustin170506 Rustin170506 force-pushed the rustin-patch-sinkv2-mq-worker-metric branch from 5269680 to 1c06141 Compare September 29, 2022 07:18
@ti-chi-bot ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 29, 2022
@Rustin170506 Rustin170506 force-pushed the rustin-patch-sinkv2-mq-worker-metric branch from 8a73306 to bb7c70a Compare September 29, 2022 08:56
@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 29, 2022
@Rustin170506 Rustin170506 added component/sink Sink component. area/ticdc Issues or PRs related to TiCDC. labels Sep 29, 2022
@hicqu
Copy link
Contributor

hicqu commented Sep 29, 2022

"title": "Kafka Outgong Bytes",

Should be Outgoing.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 29, 2022
@codecov-commenter
Copy link

codecov-commenter commented Sep 29, 2022

Codecov Report

Merging #7263 (2cc30ae) into master (d8fff7a) will increase coverage by 0.0402%.
The diff coverage is 68.7103%.

Additional details and impacted files
Flag Coverage Δ
cdc 67.2083% <81.4516%> (-0.0073%) ⬇️
dm 51.8779% <42.5000%> (+0.0404%) ⬆️
engine 61.0193% <66.9902%> (+0.1612%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master      #7263        +/-   ##
================================================
+ Coverage   59.6043%   59.6446%   +0.0402%     
================================================
  Files           790        790                
  Lines         91089      91165        +76     
================================================
+ Hits          54293      54375        +82     
+ Misses        32051      32035        -16     
- Partials       4745       4755        +10     

@Rustin170506
Copy link
Member Author

Kafka Outgong Bytes

God catch! Thanks!

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 30, 2022
@Rustin170506
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: e15682c

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 30, 2022
@ti-chi-bot
Copy link
Member

@hi-rustin: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 4d31b61 into pingcap:master Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ticdc Issues or PRs related to TiCDC. component/sink Sink component. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants