-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(dm): update python2 to python3 #7533
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: lance6716 <lance6716@gmail.com>
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/cc @purelind |
/run-dm-integration-test |
/run-dm-integration-test |
need fix UnicodeEncodeError in python3 [2022-11-07T07:28:28.217Z] get_illegal_char_task_status_failed resp= Traceback (most recent call last):
[2022-11-07T07:28:28.217Z] File "/home/jenkins/agent/workspace/dm_ghpr_integration_test/go/src/github.com/pingcap/tiflow/dm/tests/openapi/client/openapi_task_check", line 736, in <module>
[2022-11-07T07:28:28.217Z] func(*sys.argv[2:])
[2022-11-07T07:28:28.217Z] File "/home/jenkins/agent/workspace/dm_ghpr_integration_test/go/src/github.com/pingcap/tiflow/dm/tests/openapi/client/openapi_task_check", line 360, in get_illegal_char_task_status_failed
[2022-11-07T07:28:28.217Z] print("get_illegal_char_task_status_failed resp=", resp.json())
[2022-11-07T07:28:28.217Z] UnicodeEncodeError: 'ascii' codec can't encode character '\xcb' in position 120: ordinal not in range(128) |
I can pass this test in my Python 3.10.8 local environment |
@purelind and after some searching, this more often happens in python2 not python3 🤔 |
I just test this in Python 3.6.8 and will test in Python 3.10.8 later |
Signed-off-by: lance6716 lance6716@gmail.com
What problem does this PR solve?
Issue Number: ref #4159
What is changed and how it works?
CI base image does not pre-install requests library, and this library does not support python2 now. We might always use python3 for integration tests
Check List
Tests
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note