syncer(dm): fix the error when upstream has empty GTID set #7542
Conversation
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
added
do-not-merge/needs-linked-issue
release-note-none
|
/run-all-tests |
|
/cc @D3Hunter |
| @@ -0,0 +1,39 @@ | |||
| --- | |||
| name: test | |||
| task-mode: all | |||
There was a problem hiding this comment.
this is a all mode task, change to incremental? or move it into tests/all_mode
dm/tests/incremental_mode/run.sh
Outdated
| "\"alive\": true" 1 | ||
|
|
||
| echo "start task and check stage" | ||
| run_dm_ctl_with_retry $WORK_DIR "127.0.0.1:$MASTER_PORT" \ |
There was a problem hiding this comment.
check current master gtid is empty in show master status
ti-chi-bot
added
size/XL
ti-chi-bot
added
size/L
ti-chi-bot
added
size/XL
# Conflicts: # dm/tests/incremental_mode/run.sh
ti-chi-bot
added
size/L
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: d8cba8a
|
ti-chi-bot
added
the
status/can-merge
ti-chi-bot
removed
the
status/can-merge
|
/run-all-tests |
| check_rpc_alive $cur/../bin/check_worker_online 127.0.0.1:$WORKER1_PORT | ||
|
|
||
| # operate mysql config to worker | ||
| run_dm_ctl_with_retry $WORK_DIR "127.0.0.1:$MASTER_PORT" \ |
There was a problem hiding this comment.
seems no need to create source, the source is created in previous tests
|
/run-dm-integration-test |
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: 76f4d53
|
ti-chi-bot
added
the
status/can-merge
ti-chi-bot
removed
the
status/can-merge
Codecov Report
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. @@ Coverage Diff @@
## master #7542 +/- ##
================================================
- Coverage 60.0458% 59.9188% -0.1271%
================================================
Files 807 808 +1
Lines 92391 92717 +326
================================================
+ Hits 55477 55555 +78
- Misses 32099 32331 +232
- Partials 4815 4831 +16 |
|
/run-dm-integration-test |
|
@liumengya94: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: 0fce3d4
|
ti-chi-bot
added
the
status/can-merge
|
@liumengya94: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
Issue Number: close #7037
What is changed and how it works?
update
latestPosinPreviousGTIDsEventandMariadbGTIDListEventCheck List
Tests
Questions
Will it cause performance regression or break compatibility?
No
Do you need to update user documentation, design documentation or monitoring documentation?
No
Release note