Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: upgrade tidb version #7584

Merged
merged 23 commits into from
Nov 15, 2022
Merged

*: upgrade tidb version #7584

merged 23 commits into from
Nov 15, 2022

Conversation

okJiang
Copy link
Member

@okJiang okJiang commented Nov 11, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #4287

What is changed and how it works?

Check List

Tests

  • No code

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note 

`None`.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 11, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Ehco1996
  • lance6716

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed do-not-merge/needs-linked-issue labels Nov 11, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 11, 2022
@ti-chi-bot
Copy link
Member

@dveeden: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 11, 2022
@okJiang
Copy link
Member Author

okJiang commented Nov 11, 2022

/run-all-tests

@okJiang
Copy link
Member Author

okJiang commented Nov 11, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 03189e1

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 11, 2022
@okJiang
Copy link
Member Author

okJiang commented Nov 11, 2022

/run-all-tests

amyangfei
amyangfei reviewed Nov 11, 2022
View reviewed changes
Copy link
Contributor

@amyangfei amyangfei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI failed because of leak check.
Please add ignore case of goleak.IgnoreTopFunction("github.com/lestrrat-go/httprc.runFetchWorker")
ref: https://github.com/pingcap/tidb/pull/38773/files#diff-1e239c61e1a11484c01fefcc04b1af897fce9cfccfb0e7250f9484a47de8b07fR28

@okJiang
Copy link
Member Author

okJiang commented Nov 14, 2022 •
edited
Loading

CI failed because of leak check. Please add ignore case of goleak.IgnoreTopFunction("github.com/lestrrat-go/httprc.runFetchWorker") ref: pingcap/tidb#38773 (files)

It seems exists lots of error, not only goroutine leaks, https://ci2.pingcap.net/job/dm_ghpr_integration_test/10759/display/redirect. I'll take a look.

@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Nov 14, 2022
@okJiang
Copy link
Member Author

okJiang commented Nov 14, 2022

should close pingcap/tidb#39108 to pass dm-it

@okJiang
Copy link
Member Author

okJiang commented Nov 14, 2022

/run-dm-integration-test

@okJiang
Copy link
Member Author

okJiang commented Nov 15, 2022

/run-kafka-integration-test

@okJiang
Copy link
Member Author

okJiang commented Nov 15, 2022

/run-verify

@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Nov 15, 2022
@okJiang
Copy link
Member Author

okJiang commented Nov 15, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 4529637

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 15, 2022
@ti-chi-bot
Copy link
Member

@okJiang: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Nov 15, 2022
@okJiang
Copy link
Member Author

okJiang commented Nov 15, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 36b0652

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 15, 2022
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed status/can-merge Indicates a PR has been approved by a committer. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 15, 2022
@okJiang
Copy link
Member Author

okJiang commented Nov 15, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 3ff601b

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 15, 2022
@okJiang
Copy link
Member Author

okJiang commented Nov 15, 2022

/run-verify

@ti-chi-bot ti-chi-bot merged commit a419a7d into pingcap:master Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amyangfei amyangfei amyangfei left review comments

@Ehco1996 Ehco1996 Ehco1996 approved these changes

@D3Hunter D3Hunter D3Hunter approved these changes

@lance6716 lance6716 lance6716 approved these changes

@dveeden dveeden dveeden approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@okJiang @ti-chi-bot @lance6716 @dveeden @amyangfei @D3Hunter @Ehco1996