Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(engine): update lightning dependency to fix missing finishedBytes #7721

Merged
merged 5 commits into from
Nov 28, 2022

Conversation

lance6716
Copy link
Contributor

Signed-off-by: lance6716 lance6716@gmail.com

What problem does this PR solve?

Issue Number: ref #4159

What is changed and how it works?

to include pingcap/tidb#39365

Check List

Tests

  • Integration test

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

`None`.

Signed-off-by: lance6716 <lance6716@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 25, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • D3Hunter
  • okJiang

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Nov 25, 2022
@lance6716
Copy link
Contributor Author

/run-engine-integration-test

@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 25, 2022
Signed-off-by: lance6716 <lance6716@gmail.com>
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 25, 2022
@lance6716
Copy link
Contributor Author

/run-engine-integration-test

1 similar comment
@lance6716
Copy link
Contributor Author

/run-engine-integration-test

@codecov-commenter
Copy link

codecov-commenter commented Nov 25, 2022

Codecov Report

Merging #7721 (d1fec4b) into master (6d24a57) will decrease coverage by 0.0461%.
The diff coverage is 63.0350%.

Additional details and impacted files
Flag Coverage Δ
cdc 66.1818% <58.3333%> (-0.1201%) ⬇️
dm 52.1477% <55.9006%> (-0.0376%) ⬇️
engine 64.1966% <91.6666%> (+0.1998%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master      #7721        +/-   ##
================================================
- Coverage   59.9034%   59.8573%   -0.0461%     
================================================
  Files           810        811         +1     
  Lines         93255      93402       +147     
================================================
+ Hits          55863      55908        +45     
- Misses        32535      32616        +81     
- Partials       4857       4878        +21     

@lance6716
Copy link
Contributor Author

the failed case can pass in my local environment

/cc @D3Hunter @okJiang

@okJiang
Copy link
Member

okJiang commented Nov 25, 2022

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 28, 2022
@lance6716
Copy link
Contributor Author

ptal @okJiang

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 28, 2022
@lance6716
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: d1fec4b

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 28, 2022
@lance6716
Copy link
Contributor Author

/hold

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 28, 2022
@lance6716
Copy link
Contributor Author

/merge

@lance6716
Copy link
Contributor Author

/unhold

/run-all-tests tidb=master

@ti-chi-bot ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 28, 2022
@ti-chi-bot
Copy link
Member

@lance6716: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@lance6716
Copy link
Contributor Author

/run-all-tests tidb=master

@ti-chi-bot ti-chi-bot merged commit 07657c5 into pingcap:master Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants