Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

processor/sourcemanager(ticdc): add sorter stats #7748

Merged
merged 16 commits into from
Dec 1, 2022
Merged

processor/sourcemanager(ticdc): add sorter stats #7748

merged 16 commits into from
Dec 1, 2022

Conversation

Rustin170506
Copy link
Member

What problem does this PR solve?

Issue Number: ref #5928

See: #5928 (comment)

What is changed and how it works?

add sorter stats.

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Questions

Will it cause performance regression or break compatibility?

No

Do you need to update user documentation, design documentation or monitoring documentation?

No

Release note 

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 30, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hicqu
  • nongfushanquan

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 30, 2022
@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 30, 2022
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 30, 2022
@Rustin170506 Rustin170506 mentioned this pull request Nov 30, 2022
Closed
@Rustin170506 Rustin170506 requested a review from hicqu November 30, 2022 08:55
@Rustin170506 Rustin170506 added component/sorter Sorter component. area/ticdc Issues or PRs related to TiCDC. labels Nov 30, 2022
@Rustin170506
Copy link
Member Author

/run-all-tests

1 similar comment
@Rustin170506
Copy link
Member Author

/run-all-tests

@purelind
Copy link
Collaborator

/run-check-issue-triage-complete

@hicqu
Copy link
Contributor

hicqu commented Nov 30, 2022

Rest LGTM.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 30, 2022
@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 1, 2022
@Rustin170506 Rustin170506 requested a review from hicqu December 1, 2022 02:46
@codecov-commenter
Copy link

codecov-commenter commented Dec 1, 2022 •
edited
Loading

Codecov Report

Merging #7748 (7c6ec40) into master (b0f5a0b) will increase coverage by 4.9433%.
The diff coverage is 49.0285%.

❗ Current head 7c6ec40 differs from pull request most recent head f3f48cb. Consider uploading reports for the commit f3f48cb to get more accurate results

Additional details and impacted files
Flag Coverage Δ
cdc 66.1850% <43.5073%> (?)
dm 52.2780% <81.2500%> (+0.1310%) ⬆️
engine 64.3319% <ø> (+0.0474%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master      #7748        +/-   ##
================================================
+ Coverage   55.0067%   59.9501%   +4.9433%     
================================================
  Files           415        812       +397     
  Lines         52739      93798     +41059     
================================================
+ Hits          29010      56232     +27222     
- Misses        20957      32675     +11718     
- Partials       2772       4891      +2119

@Rustin170506
Copy link
Member Author

/run-all-tests

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 1, 2022
@Rustin170506
Copy link
Member Author

/run-all-tests tidb=f5487e3f2596cdd63ae9840606c7fff3fb539e03

@Rustin170506
Copy link
Member Author

/merge

/run-all-tests tidb=f5487e3f2596cdd63ae9840606c7fff3fb539e03

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 8d665f4

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 1, 2022
@hicqu
Copy link
Contributor

hicqu commented Dec 1, 2022

/merge

@Rustin170506
Copy link
Member Author

/run-all-tests tidb=f5487e3f2596cdd63ae9840606c7fff3fb539e03

@ti-chi-bot ti-chi-bot merged commit 9c3eddb into pingcap:master Dec 1, 2022
@Rustin170506 Rustin170506 deleted the rustin-patch-sourcemanager-stats branch December 1, 2022 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nongfushanquan nongfushanquan nongfushanquan approved these changes

@hicqu hicqu hicqu approved these changes

Assignees
No one assigned
Labels
area/ticdc Issues or PRs related to TiCDC. component/sorter Sorter component. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Rustin170506 @ti-chi-bot @purelind @hicqu @codecov-commenter @nongfushanquan