Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

processsor/sinkmanager(ticdc): add some metrics for pull-based-sink #7761

Merged
merged 8 commits into from
Dec 1, 2022
Merged

processsor/sinkmanager(ticdc): add some metrics for pull-based-sink #7761

merged 8 commits into from
Dec 1, 2022

Conversation

hicqu
Copy link
Contributor

@hicqu hicqu commented Dec 1, 2022

Signed-off-by: qupeng qupeng@pingcap.com

What problem does this PR solve?

Issue Number: ref #5928

What is changed and how it works?

Add some metrics for pull-based-sink.

Check List

Tests

  • Unit test

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note 

None

@hicqu
add some metrics for pull-based-sink
64f013a 
Signed-off-by: qupeng <qupeng@pingcap.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 1, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • amyangfei
  • hi-rustin

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 1, 2022
hicqu added 2 commits December 1, 2022 13:56
@hicqu
fix typo
de1e2d4 
Signed-off-by: qupeng <qupeng@pingcap.com>
@hicqu
make fmt
d1010a5 
Signed-off-by: qupeng <qupeng@pingcap.com>
@hicqu
Copy link
Contributor Author

hicqu commented Dec 1, 2022

/run-all-tests

1 similar comment
@hicqu
Copy link
Contributor Author

hicqu commented Dec 1, 2022

/run-all-tests

Rustin170506
Rustin170506 reviewed Dec 1, 2022
View reviewed changes
Copy link
Member

@Rustin170506 Rustin170506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

cdc/processor/manager.go Outdated Show resolved Hide resolved
cdc/processor/sourcemanager/engine/pebble/event_sorter.go Show resolved Hide resolved
cdc/processor/sourcemanager/engine/pebble/event_sorter.go Show resolved Hide resolved
cdc/processor/sinkmanager/redo_cache.go Show resolved Hide resolved
@hicqu @Rustin170506
Update cdc/processor/manager.go
b1842fe 
Co-authored-by: 二手掉包工程师 <rustin.liu@gmail.com>
@hicqu
Copy link
Contributor Author

hicqu commented Dec 1, 2022

/run-all-tests

@fubinzh fubinzh mentioned this pull request Dec 1, 2022
Closed
amyangfei
amyangfei reviewed Dec 1, 2022
View reviewed changes
cdc/processor/sinkmanager/metrics.go Outdated Show resolved Hide resolved
cdc/processor/sinkmanager/redo_cache.go Outdated Show resolved Hide resolved
@Rustin170506 Rustin170506 added component/sink Sink component. area/ticdc Issues or PRs related to TiCDC. labels Dec 1, 2022
@hicqu
address comments
6d4bb2d 
Signed-off-by: qupeng <qupeng@pingcap.com>
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 1, 2022
@Rustin170506 Rustin170506 changed the title sinkv2(cdc): add some metrics for pull-based-sink processsor/sinkmanager(ticdc): add some metrics for pull-based-sink Dec 1, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 1, 2022
@amyangfei
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 6d4bb2d

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 1, 2022
@hicqu
Copy link
Contributor Author

hicqu commented Dec 1, 2022

/merge

@hicqu
fix tests
75a2889 
Signed-off-by: qupeng <qupeng@pingcap.com>
@hicqu
Copy link
Contributor Author

hicqu commented Dec 1, 2022

/run-all-tests

@Rustin170506
Copy link
Member

/run-all-tests tidb=f5487e3f2596cdd63ae9840606c7fff3fb539e03

@Rustin170506
Copy link
Member

/run-check-issue-triage-complete

@hicqu
address comments
dd3da42 
Signed-off-by: qupeng <qupeng@pingcap.com>
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Dec 1, 2022
@hicqu
Copy link
Contributor Author

hicqu commented Dec 1, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: dd3da42

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 1, 2022
@Rustin170506
Copy link
Member

/run-all-tests tidb=f5487e3f2596cdd63ae9840606c7fff3fb539e03

@Rustin170506
Copy link
Member

/run-all-tests tidb=f5487e3f2596cdd63ae9840606c7fff3fb539e03

@ti-chi-bot ti-chi-bot merged commit 8579aaf into pingcap:master Dec 1, 2022
@hicqu hicqu deleted the pull-based-sink-metrics branch December 1, 2022 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nongfushanquan nongfushanquan nongfushanquan approved these changes

@Rustin170506 Rustin170506 Rustin170506 approved these changes

@amyangfei amyangfei amyangfei approved these changes

Assignees
No one assigned
Labels
area/ticdc Issues or PRs related to TiCDC. component/sink Sink component. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hicqu @ti-chi-bot @amyangfei @Rustin170506 @nongfushanquan