Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

processor/sourcemanager(ticdc): move mounted iter into sourceManager #7769

Merged
merged 2 commits into from
Dec 1, 2022
Merged

processor/sourcemanager(ticdc): move mounted iter into sourceManager #7769

merged 2 commits into from
Dec 1, 2022

Conversation

Rustin170506
Copy link
Member

What problem does this PR solve?

Issue Number: ref #5928

See: #5928 (comment)

What is changed and how it works?

move mounted iter into sourceManager.

Check List

Tests

  • Unit test

Questions

Will it cause performance regression or break compatibility?

No

Do you need to update user documentation, design documentation or monitoring documentation?

No

Release note 

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 1, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hicqu
  • nongfushanquan

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 1, 2022
@Rustin170506 Rustin170506 force-pushed the rustin-patch-sourcemanager-move branch from 68c9a88 to 86f4b3f Compare December 1, 2022 10:47
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 1, 2022
@Rustin170506 Rustin170506 added component/sorter Sorter component. area/ticdc Issues or PRs related to TiCDC. labels Dec 1, 2022
@Rustin170506
Copy link
Member Author

/run-all-tests tidb=f5487e3f2596cdd63ae9840606c7fff3fb539e03

@Rustin170506 Rustin170506 added the require-LGT1 Indicates that the PR requires an LGTM. label Dec 1, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 1, 2022
@Rustin170506 Rustin170506 removed the require-LGT1 Indicates that the PR requires an LGTM. label Dec 1, 2022
@Rustin170506 Rustin170506 mentioned this pull request Dec 1, 2022
Closed
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 1, 2022
@Rustin170506
Copy link
Member Author

/merge

/run-all-tests tidb=f5487e3f2596cdd63ae9840606c7fff3fb539e03

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 2413c02

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 1, 2022
@ti-chi-bot ti-chi-bot merged commit 5f624b7 into pingcap:master Dec 1, 2022
@Rustin170506 Rustin170506 deleted the rustin-patch-sourcemanager-move branch December 1, 2022 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nongfushanquan nongfushanquan nongfushanquan approved these changes

@hicqu hicqu hicqu approved these changes

Assignees
No one assigned
Labels
area/ticdc Issues or PRs related to TiCDC. component/sorter Sorter component. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Rustin170506 @ti-chi-bot @hicqu @nongfushanquan