-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expression_filter(dm): fix updateOldExprs and updateNewExprs length not same #7779
Conversation
Signed-off-by: lance6716 <lance6716@gmail.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Codecov Report
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. @@ Coverage Diff @@
## master #7779 +/- ##
================================================
+ Coverage 55.0067% 60.0006% +4.9939%
================================================
Files 415 813 +398
Lines 52739 94044 +41305
================================================
+ Hits 29010 56427 +27417
- Misses 20957 32730 +11773
- Partials 2772 4887 +2115 |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 020f514
|
@lance6716: Your PR was out of date, I have automatically updated it for you. If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/run-all-tests |
/run-engine-integration-test |
In response to a cherrypick label: new pull request created: #7829. |
In response to a cherrypick label: new pull request created: #7830. |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: lance6716 lance6716@gmail.com
What problem does this PR solve?
Issue Number: close #7774
What is changed and how it works?
treat updateOldExprs and updateNewExprs as a whole when caching
Check List
Tests
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note