-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cdc: replace tableID with Span in TableExecutor and agent #7793
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/run-all-tests |
* Replace TableID with tablepb.Span in TableExecutor * Replace TableID with tablepb.Span in agent Signed-off-by: Neil Shen <overvenus@gmail.com>
95ade62
to
56d985b
Compare
/run-all-tests tidb=f5487e3f2596cdd63ae9840606c7fff3fb539e03 |
cdc/processor/processor.go
Outdated
zap.Uint64("checkpointTs", checkpointTs)) | ||
return checkpointTs, true | ||
} | ||
|
||
// GetAllCurrentTables implements TableExecutor interface. | ||
func (p *processor) GetAllCurrentTables() []model.TableID { | ||
func (p *processor) GetAllCurrentTables() int { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible that we care about all tableID ?
How about adding a new method GetAllTableCount
here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked code base, no one needs tableID. I will rename the method.
Signed-off-by: Neil Shen <overvenus@gmail.com>
Signed-off-by: Neil Shen <overvenus@gmail.com>
Signed-off-by: Neil Shen <overvenus@gmail.com>
/run-all-tests |
Signed-off-by: Neil Shen <overvenus@gmail.com>
/run-all-tests |
kafka tests timeout, but there is no ERROR or WARN log from schedulerv3. |
/run-all-tests |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: cd4991c
|
/run-integration-test |
What problem does this PR solve?
Issue Number: ref #7720
What is changed and how it works?
This PR is compatible with older TiCDC, because #7723 convert table ID and span in message automatically.
Check List
Tests
Questions
Will it cause performance regression or break compatibility?
No
Do you need to update user documentation, design documentation or monitoring documentation?
No
Release note