Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scheduler(ticdc): replace tableID with Span #7806

Merged
merged 4 commits into from
Dec 16, 2022
Merged

scheduler(ticdc): replace tableID with Span #7806

merged 4 commits into from
Dec 16, 2022

Conversation

overvenus
Copy link
Member

What problem does this PR solve?

Issue Number: ref #7720

What is changed and how it works?

Replace tableID with tablepb.Span in following packages:

  • scheduler/internal/v3
  • scheduler/internal/v3/member
  • scheduler/internal/v3/replication
  • scheduler/internal/v3/scheduler

There is no change other than replacing tableID with tablepb.Span.

Check List

Tests

  • Unit test
  • Integration test

Questions

Will it cause performance regression or break compatibility?

No.

Do you need to update user documentation, design documentation or monitoring documentation?

No.

Release note 

None

@overvenus overvenus added component/scheduler TiCDC inner scheduler component. area/ticdc Issues or PRs related to TiCDC. labels Dec 5, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 5, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • 3AceShowHand
  • sdojjy

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 5, 2022
@overvenus overvenus mentioned this pull request Dec 5, 2022
Closed
22 tasks
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 7, 2022
@overvenus
scheduler: replace tableID with Span
8c0fd4d 
Signed-off-by: Neil Shen <overvenus@gmail.com>
@overvenus overvenus force-pushed the span-replication/owner branch from e174f5c to 8c0fd4d Compare December 12, 2022 05:57
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 12, 2022
@overvenus overvenus marked this pull request as ready for review December 12, 2022 05:57
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 12, 2022
@overvenus
address lints
fcb961f 
Signed-off-by: Neil Shen <overvenus@gmail.com>
@overvenus
Copy link
Member Author

/run-all-tests

3AceShowHand
3AceShowHand reviewed Dec 14, 2022
View reviewed changes
cdc/scheduler/internal/v3/replication/replication_set.go
return nil, nil
}
// Ignore move table if
// 1) it's not in Replicating state or
// 2) the dest capture is the primary.
if r.State != ReplicationSetStateReplicating || r.Primary == dest {
log.Warn("schedulerv3: move table is ignored",
zap.Any("replicationSet", r), zap.Int64("tableID", r.TableID))
zap.Any("replicationSet", r), zap.Int64("tableID", r.Span.TableID))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better to put tableID before replicationSet, since it's shorter, easy to read.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 14, 2022
@overvenus
scheduler(ticdc): convert table ID to span in move table API
2895616 
Signed-off-by: Neil Shen <overvenus@gmail.com>
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 16, 2022
@overvenus
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 2895616

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 16, 2022
@ti-chi-bot ti-chi-bot merged commit 92772d4 into pingcap:master Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@3AceShowHand 3AceShowHand 3AceShowHand approved these changes

@sdojjy sdojjy sdojjy approved these changes

@asddongmen asddongmen Awaiting requested review from asddongmen

Assignees
No one assigned
Labels
area/ticdc Issues or PRs related to TiCDC. component/scheduler TiCDC inner scheduler component. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@overvenus @ti-chi-bot @sdojjy @3AceShowHand