Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

processor/sinkmanager(ticdc): report checkpoint ts and update last position correctly (#7819) #7828

Merged
merged 6 commits into from
Dec 6, 2022
Merged

processor/sinkmanager(ticdc): report checkpoint ts and update last position correctly (#7819) #7828

merged 6 commits into from
Dec 6, 2022

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #7819

What problem does this PR solve?

Issue Number: close #7760

close #7798
close #7813
close #7814

What is changed and how it works?

  • Report checkpoint ts correctly when the table is added.
  • Update the last position correctly in sink worker.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

Questions

Will it cause performance regression or break compatibility?

No

Do you need to update user documentation, design documentation or monitoring documentation?

No

Release note 

None

@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. area/ticdc Issues or PRs related to TiCDC. component/sink Sink component. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels Dec 6, 2022
@ti-chi-bot ti-chi-bot mentioned this pull request Dec 6, 2022
Merged
@Rustin170506
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: b435221

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 6, 2022
@Rustin170506
Copy link
Member

/run-all-tests

@sre-bot sre-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Dec 6, 2022
@Rustin170506
Copy link
Member

/run-all-tests

@ti-chi-bot ti-chi-bot merged commit f766d77 into pingcap:release-6.5 Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Rustin170506 Rustin170506

Labels
area/ticdc Issues or PRs related to TiCDC. cherry-pick-approved Cherry pick PR approved by release team. component/sink Sink component. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ti-chi-bot @Rustin170506 @sre-bot