Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

puller,processor: replace table ID with Span #7832

Merged
merged 8 commits into from
Dec 9, 2022
Merged

puller,processor: replace table ID with Span #7832

merged 8 commits into from
Dec 9, 2022

Conversation

overvenus
Copy link
Member

What problem does this PR solve?

Issue Number: ref #7720

What is changed and how it works?

  • Replace TableID with tablepb.Span in processor
  • Replace TableID with tablepb.Span in puller

Check List

Tests

  • Unit test
  • Integration test

Questions

Will it cause performance regression or break compatibility?

No.

Do you need to update user documentation, design documentation or monitoring documentation?

No.

Release note 

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 7, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • 3AceShowHand
  • sdojjy

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 7, 2022
@overvenus overvenus mentioned this pull request Dec 7, 2022
Closed
22 tasks
@overvenus overvenus added component/scheduler TiCDC inner scheduler component. area/ticdc Issues or PRs related to TiCDC. labels Dec 7, 2022
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 7, 2022
@overvenus
processor(ticdc): replace tableID with tablepb.Span
008e4ef 
Signed-off-by: Neil Shen <overvenus@gmail.com>
@overvenus
puller,processor: replace table ID with Span
2b2a041 
Signed-off-by: Neil Shen <overvenus@gmail.com>
@overvenus overvenus force-pushed the span-replication/puller branch from 02bf9c8 to 2b2a041 Compare December 8, 2022 06:36
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 8, 2022
@overvenus overvenus marked this pull request as ready for review December 8, 2022 06:36
@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 8, 2022
@overvenus
make fmt
eb42310 
Signed-off-by: Neil Shen <overvenus@gmail.com>
@overvenus
Copy link
Member Author

/run-all-tests

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 9, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 9, 2022
@overvenus
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 7ddd377

@ti-chi-bot ti-chi-bot added status/can-merge Indicates a PR has been approved by a committer. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Dec 9, 2022
@overvenus
Copy link
Member Author

/run-integration-tests

@Rustin170506
Copy link
Member

/hold

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 9, 2022
@Rustin170506
Copy link
Member

/unhold

@ti-chi-bot ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 9, 2022
@Rustin170506
Copy link
Member

/run-all-tests

@ti-chi-bot
Copy link
Member

@overvenus: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

trigger some heavy tests which will not run always when PR updated.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@Rustin170506
Copy link
Member

/run-all-tests

@ti-chi-bot ti-chi-bot merged commit 12f778d into pingcap:master Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@3AceShowHand 3AceShowHand 3AceShowHand approved these changes

@sdojjy sdojjy sdojjy approved these changes

@Rustin170506 Rustin170506 Awaiting requested review from Rustin170506

@asddongmen asddongmen Awaiting requested review from asddongmen

Assignees
No one assigned
Labels
area/ticdc Issues or PRs related to TiCDC. component/scheduler TiCDC inner scheduler component. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@overvenus @ti-chi-bot @Rustin170506 @sdojjy @3AceShowHand