Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

metrics(ticdc): refine exp boundary, record large row from 2k size #7861

Merged
merged 3 commits into from
Dec 9, 2022
Merged

metrics(ticdc): refine exp boundary, record large row from 2k size #7861

merged 3 commits into from
Dec 9, 2022

Conversation

amyangfei
Copy link
Contributor

@amyangfei amyangfei commented Dec 9, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #5928

What is changed and how it works?

  • Correct some comments of ExponentialBuckets boundary, the upper boundary should be start * (factor ^ (count - 1))
  • Set largeRowSizeLowBound to 2K, original 128K is too large for a single row change.

Check List

Tests

  • Unit test
  • Integration test

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note 

None

@amyangfei amyangfei added the area/ticdc Issues or PRs related to TiCDC. label Dec 9, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 9, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hi-rustin
  • nongfushanquan

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 9, 2022
@amyangfei amyangfei added the status/ptal Could you please take a look? label Dec 9, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 9, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 9, 2022
@amyangfei
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: c4adf36

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 9, 2022
@amyangfei
Copy link
Contributor Author

/run-integration-test

1 similar comment
@amyangfei
Copy link
Contributor Author

/run-integration-test

@amyangfei amyangfei added the needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. label Dec 9, 2022
@amyangfei
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

@amyangfei: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

trigger some heavy tests which will not run always when PR updated.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@amyangfei
Copy link
Contributor Author

/run-kafka-integration-test

@ti-chi-bot ti-chi-bot merged commit 7aef2a0 into pingcap:master Dec 9, 2022
@ti-chi-bot ti-chi-bot mentioned this pull request Dec 9, 2022
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #7867.

@amyangfei amyangfei deleted the refine-sinkv2-metrics branch December 9, 2022 08:51
ti-chi-bot added a commit that referenced this pull request Jan 6, 2023
@ti-chi-bot
metrics(ticdc): refine exp boundary, record large row from 2k size (#…
e201f10 
…7861) (#7867)

ref #5928
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nongfushanquan nongfushanquan nongfushanquan approved these changes

@Rustin170506 Rustin170506 Rustin170506 approved these changes

@hicqu hicqu Awaiting requested review from hicqu

Assignees
No one assigned
Labels
area/ticdc Issues or PRs related to TiCDC. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. status/ptal Could you please take a look?
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@amyangfei @ti-chi-bot @Rustin170506 @nongfushanquan