Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sinkv2(cdc): add busy ratio metric for conflict detector #8055

Closed
wants to merge 7 commits into from

Conversation

hicqu
Copy link
Contributor

@hicqu hicqu commented Jan 11, 2023

What problem does this PR solve?

Issue Number: ref #5928

What is changed and how it works?

  • Add a metrics for conflict detector background goroutine busy ratio
  • Use slice instead of BTree for depender list, because all events are already sorted

Check List

Tests

  • Unit test
  • Manual bench
    With the patch : BenchmarkHighConflictsWithManyKeys-16 1230 855992 ns/op
    Without the patch: BenchmarkHighConflictsWithManyKeys-16 1501 961344 ns/op

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

None

Signed-off-by: qupeng <qupeng@pingcap.com>
Signed-off-by: qupeng <qupeng@pingcap.com>
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 11, 2023
@hicqu hicqu requested a review from amyangfei January 12, 2023 07:53
@hicqu hicqu changed the title Conflict detector busy ratio sinkv2(cdc): add busy ratio metric for conflict detector Jan 13, 2023
@hicqu
Copy link
Contributor Author

hicqu commented Feb 8, 2023

The PR seems not necessary. Test result shows the conflict detector background thread is always free enough.

@hicqu hicqu closed this Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants