Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config(ticdc): move region-per-span to changefeed config #8100

Merged
merged 7 commits into from
Jan 19, 2023
Merged

config(ticdc): move region-per-span to changefeed config #8100

merged 7 commits into from
Jan 19, 2023

Conversation

overvenus
Copy link
Member

@overvenus overvenus commented Jan 17, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #7720

What is changed and how it works?

Move region-per-span config to changefeed.

Check List

Tests

  • Unit test
  • Manual test
  1. Create a changefeed using following changefeed.toml
  2. Update an existing changefeed (without scale out) using following changefeed.toml
[scheduler]
region-per-span = 10000

Questions

Will it cause performance regression or break compatibility?

No

Do you need to update user documentation, design documentation or monitoring documentation?

No

Release note 

None

@overvenus
config(ticdc): move region-per-span to changefeed config
c7121a1 
Signed-off-by: Neil Shen <overvenus@gmail.com>
@overvenus
fix scheduler compatibility
ad56d9d 
Signed-off-by: Neil Shen <overvenus@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 17, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • CharlesCheung96
  • asddongmen

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 17, 2023
@overvenus overvenus mentioned this pull request Jan 17, 2023
Closed
22 tasks
@overvenus
api(ticdc): fix changefeed scheduler config
19d02b3 
Signed-off-by: Neil Shen <overvenus@gmail.com>
@overvenus overvenus mentioned this pull request Jan 17, 2023
Merged
15 tasks
@overvenus
fix tests
35233df 
Signed-off-by: Neil Shen <overvenus@gmail.com>
@overvenus overvenus marked this pull request as ready for review January 17, 2023 13:10
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 17, 2023
@overvenus
fix tests
ff5029b 
Signed-off-by: Neil Shen <overvenus@gmail.com>
@overvenus
Merge branch 'master' into span-replication/config
493bf80
@overvenus
Copy link
Member Author

/run-all-tests

@overvenus
Copy link
Member Author

/run-kafka-integration-test

@overvenus
tests(ticdc): add scale out changefeed update test
b126a31 
Signed-off-by: Neil Shen <overvenus@gmail.com>
@overvenus
Copy link
Member Author

/run-all-tests

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 19, 2023
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 19, 2023
@overvenus
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: b126a31

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 19, 2023
@overvenus
Copy link
Member Author

/run-all-tests

@overvenus
Copy link
Member Author

/run-verify

@overvenus
Copy link
Member Author

/run-kafka-integration-test pd=7ca1b9aa2ca6b6ee6be4696d377e9065b1b09359
/run-integration-tests pd=7ca1b9aa2ca6b6ee6be4696d377e9065b1b09359

@ti-chi-bot ti-chi-bot merged commit 0914a56 into pingcap:master Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CharlesCheung96 CharlesCheung96 CharlesCheung96 approved these changes

@asddongmen asddongmen asddongmen approved these changes

@3AceShowHand 3AceShowHand 3AceShowHand approved these changes

@sdojjy sdojjy Awaiting requested review from sdojjy

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@overvenus @ti-chi-bot @3AceShowHand @asddongmen @CharlesCheung96