-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*(all): update dependencies on tidb and pd. #8126
Merged
Merged
Changes from 1 commit
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
dde7691
fix get source id error
asddongmen f8011ce
add unit test
asddongmen 022862a
add unit test
asddongmen 72c0087
fix fmt
asddongmen 053c101
fix ut
asddongmen 34b01cd
fix ut
asddongmen 9c47ff4
fix ut
asddongmen dee9636
fix ut
asddongmen cb0aa87
add arch check to makefile
asddongmen 9a0d3db
format makefile
asddongmen 7bc84de
merge upstream/master
asddongmen 37f27f7
update dependencies
asddongmen 4181e92
update dependencies to master
asddongmen 9a86faa
fix ut build error
asddongmen c46cd35
fix some retryable MySQL pattern
lance6716 712b87a
fix DM IT
lance6716 2affa94
try fix some tests
lance6716 7ad35b2
revert negligent change of go.mod
asddongmen ae2cb54
Merge branch 'fix-get-source-id' of github.com:asddongmen/ticdc into …
asddongmen 4cd5a82
fix DM IT
lance6716 6148e9b
Merge branch 'fix-get-source-id' of github.com:asddongmen/ticdc into …
lance6716 ccaf0cb
fix DM IT
lance6716 1a060a7
fix DM IT
lance6716 310f0fe
fix some UT and IT
lance6716 696fa26
fix more
lance6716 775f97a
fix a DM IT
lance6716 c42dab2
address comments
asddongmen 4b2e19b
address comments again
asddongmen 03e6f46
remove debug log
asddongmen f1628fd
address comments
asddongmen 3fd5f58
Update Makefile
asddongmen b35f4e9
Merge branch 'master' into fix-get-source-id
ti-chi-bot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Update Makefile
Co-authored-by: 二手掉包工程师 <rustin.liu@gmail.com>
- Loading branch information
commit 3fd5f58297874a81f4b58b2cbd20ce9081106648
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What if someone cross compile macOS TiCDC on a linux machine?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think only GOOS matters.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! You are right, only GOOS matters, but no matter set
CGO_ENABLED=0
orCGO_ENABLED=1
runGOOS=darwin make cdc
fails.I revert related changes and run the following commands:
Do you have any idea to fix this problem?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pingcap/tidb#41165
use
CGO_ENABLED=1
is the only way to build on darwin.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but can't build a darwin cdc on linux machine.