Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sinkv2(ticdc): sink manager handle error initialization and send error to default to prevent block #8187

Closed
wants to merge 4 commits into from
Closed

sinkv2(ticdc): sink manager handle error initialization and send error to default to prevent block #8187

wants to merge 4 commits into from

Conversation

3AceShowHand
Copy link
Contributor

@3AceShowHand 3AceShowHand commented Feb 7, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: close #8174

What is changed and how it works?

  • set up sinkManager error channel to prevent it's nil.

Check List

Tests

  • Unit test
  • Manual test (add detailed scripts or steps below)

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note 

`None`

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 8, 2023
@3AceShowHand
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot added needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. and removed do-not-merge/needs-triage-completed labels Feb 8, 2023
@3AceShowHand 3AceShowHand changed the title [DNM] sink(ticdc): fix error channel sinkv2(ticdc): sink manager handle error initialization and send error to default to prevent block on error Feb 8, 2023
@3AceShowHand 3AceShowHand changed the title sinkv2(ticdc): sink manager handle error initialization and send error to default to prevent block on error sinkv2(ticdc): sink manager handle error initialization and send error to default to prevent block Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hicqu hicqu Awaiting requested review from hicqu

@Rustin170506 Rustin170506 Awaiting requested review from Rustin170506

Assignees
No one assigned
Labels
needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cdc changefeed stucks
2 participants
@3AceShowHand @ti-chi-bot