Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*(ticdc): fix some major problems about pull-based-sink (#8179) #8197

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #8179

What problem does this PR solve?

Issue Number: close #8103
Issue Number: close #8157
Issue Number: close #8185
Issue Number: close #8174

What is changed and how it works?

  • record mounter internal memory usage into memory quota;
  • limit task upperbound with schema storage resolved timestamp;
  • Make memquota.MemoryQuota more lock-free.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

None

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. labels Feb 8, 2023
@ti-chi-bot ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels Feb 8, 2023
Signed-off-by: qupeng <qupeng@pingcap.com>
Signed-off-by: qupeng <qupeng@pingcap.com>
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Feb 8, 2023
@hicqu
Copy link
Contributor

hicqu commented Feb 8, 2023

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 40dd0ca

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 8, 2023
@codecov-commenter
Copy link

codecov-commenter commented Feb 8, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release-6.5@5f556c7). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 2d3d3f7 differs from pull request most recent head 40dd0ca. Consider uploading reports for the commit 40dd0ca to get more accurate results

Additional details and impacted files
Flag Coverage Δ
cdc 65.6694% <0.0000%> (?)
engine 66.5762% <0.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             release-6.5      #8197   +/-   ##
================================================
  Coverage               ?   65.8923%           
================================================
  Files                  ?        575           
  Lines                  ?      55530           
  Branches               ?          0           
================================================
  Hits                   ?      36590           
  Misses                 ?      16138           
  Partials               ?       2802           

@ti-chi-bot ti-chi-bot merged commit b5419b6 into pingcap:release-6.5 Feb 8, 2023
@hicqu hicqu deleted the cherry-pick-8179-to-release-6.5 branch February 9, 2023 05:37
@VelocityLight VelocityLight added do-not-merge/cherry-pick-not-approved cherry-pick-approved Cherry pick PR approved by release team. and removed cherry-pick-approved Cherry pick PR approved by release team. do-not-merge/cherry-pick-not-approved labels Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants