Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redo(ticdc): set default timeout for accessing external storage to 15 minutes (#8181) #8205

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #8181

What problem does this PR solve?

Issue Number: close #8089

What is changed and how it works?

Set the default timeout for accessing external storage to 15 minutes

Check List

Tests

  • Unit test
  • Integration test
  • Manual test
  1. run consistent_replicate_storage_s3 test
  2. stop minio manually
  3. sleep 5 minutes
  4. restart minio
    The test passed and the following logs were found:
    image

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

`Fix the issue that redo log cannot tolerate network faults for more than 6 seconds`.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-6.1 This PR is cherry-picked to release-6.1 from a source PR. labels Feb 9, 2023
@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 9, 2023
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Feb 15, 2023
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 15, 2023
@VelocityLight VelocityLight added do-not-merge/cherry-pick-not-approved cherry-pick-approved Cherry pick PR approved by release team. and removed cherry-pick-approved Cherry pick PR approved by release team. do-not-merge/cherry-pick-not-approved labels Feb 21, 2023
@VelocityLight VelocityLight added do-not-merge/cherry-pick-not-approved cherry-pick-approved Cherry pick PR approved by release team. and removed cherry-pick-approved Cherry pick PR approved by release team. do-not-merge/cherry-pick-not-approved labels Mar 23, 2023
@CharlesCheung96 CharlesCheung96 force-pushed the cherry-pick-8181-to-release-6.1 branch from 9ebd453 to c82999d Compare March 27, 2023 02:06
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 27, 2023
@CharlesCheung96 CharlesCheung96 force-pushed the cherry-pick-8181-to-release-6.1 branch from c82999d to 8ef7a68 Compare March 27, 2023 02:45
@CharlesCheung96
Copy link
Contributor

/run-all-tests

@codecov-commenter
Copy link

codecov-commenter commented Mar 27, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release-6.1@e85be56). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head ca7733c differs from pull request most recent head 4842052. Consider uploading reports for the commit 4842052 to get more accurate results

Additional details and impacted files
Flag Coverage Δ
cdc 65.6753% <0.0000%> (?)
dm 57.7111% <0.0000%> (?)
engine 66.7221% <0.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             release-6.1      #8205   +/-   ##
================================================
  Coverage               ?   61.4263%           
================================================
  Files                  ?        902           
  Lines                  ?     122148           
  Branches               ?          0           
================================================
  Hits                   ?      75031           
  Misses                 ?      40758           
  Partials               ?       6359           

@CharlesCheung96
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 8ef7a68

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 27, 2023
@ti-chi-bot
Copy link
Member Author

@ti-chi-bot: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

trigger some heavy tests which will not run always when PR updated.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@CharlesCheung96
Copy link
Contributor

/run-verify

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-6.1 This PR is cherry-picked to release-6.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants