Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sorter(ticdc): use correct cgroup memory limit in some scenarios (#8589) #8625

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #8589

What problem does this PR solve?

Issue Number: close #8588

What is changed and how it works?

Use a better way to fetch cgroup memory limit.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

Have been verified in the following scenarios

  • systemd cgroup enabled
  • systemd cgroup not enabled
  • docker run container under containerd-shim-runc-v2 with memory limit
  • docker run container under containerd-shim-runc-v2 without memory limit
  • K8s starts pod with memory limit
  • K8s starts pod without memory limit

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

Use correct cgroup memory limit in sorter engine under some scenarios.

@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Mar 22, 2023
@ti-chi-bot
Copy link
Member Author

@ti-chi-bot: This cherry pick PR is for a release branch and has not yet been approved by release team.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved by the collaborators.

AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot added area/ticdc Issues or PRs related to TiCDC. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-7.0 This PR is cherry-picked to release-7.0 from a source PR. labels Mar 22, 2023
@codecov-commenter
Copy link

codecov-commenter commented Mar 22, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release-7.0@a544daa). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head bbf462c differs from pull request most recent head b08916c. Consider uploading reports for the commit b08916c to get more accurate results

Additional details and impacted files
Flag Coverage Δ
cdc 66.3506% <0.0000%> (?)
dm 53.4119% <0.0000%> (?)
engine 65.4295% <0.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             release-7.0      #8625   +/-   ##
================================================
  Coverage               ?   60.8232%           
================================================
  Files                  ?        803           
  Lines                  ?      94528           
  Branches               ?          0           
================================================
  Hits                   ?      57495           
  Misses                 ?      32117           
  Partials               ?       4916           

@amyangfei amyangfei closed this Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ticdc Issues or PRs related to TiCDC. do-not-merge/cherry-pick-not-approved release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-7.0 This PR is cherry-picked to release-7.0 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants