-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sorter(ticdc): use correct cgroup memory limit in some scenarios (#8589) #8625
sorter(ticdc): use correct cgroup memory limit in some scenarios (#8589) #8625
Conversation
- Fix unawareness of systemd cgroup scenario
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
@ti-chi-bot: This cherry pick PR is for a release branch and has not yet been approved by release team. To merge this cherry pick, it must first be approved by the collaborators. AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. @@ Coverage Diff @@
## release-7.0 #8625 +/- ##
================================================
Coverage ? 60.8232%
================================================
Files ? 803
Lines ? 94528
Branches ? 0
================================================
Hits ? 57495
Misses ? 32117
Partials ? 4916 |
This is an automated cherry-pick of #8589
What problem does this PR solve?
Issue Number: close #8588
What is changed and how it works?
Use a better way to fetch cgroup memory limit.
Check List
Tests
Have been verified in the following scenarios
docker run
container undercontainerd-shim-runc-v2
with memory limitdocker run
container undercontainerd-shim-runc-v2
without memory limitQuestions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note