Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mounter(ticdc): support row level checksum verification #8780

Merged
merged 22 commits into from
Apr 13, 2023
Merged

mounter(ticdc): support row level checksum verification #8780

merged 22 commits into from
Apr 13, 2023

Conversation

3AceShowHand
Copy link
Contributor

@3AceShowHand 3AceShowHand commented Apr 12, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: close #8777, close #8791

What is changed and how it works?

  • Extract the checksum and compare it.

Check List

Tests

  • Unit test

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note 

Mounter support row level checksum verification

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 12, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • asddongmen
  • overvenus

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 12, 2023
@ti-chi-bot ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 12, 2023
@3AceShowHand
Copy link
Contributor Author

/test verify

overvenus
overvenus reviewed Apr 13, 2023
View reviewed changes
cdc/entry/mounter.go Outdated Show resolved Hide resolved
@3AceShowHand
Copy link
Contributor Author

/test verify

overvenus
overvenus approved these changes Apr 13, 2023
View reviewed changes
Copy link
Member

@overvenus overvenus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add an integration test?

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 13, 2023
@3AceShowHand
Copy link
Contributor Author

Could you add an integration test?

I will add an integration test to cover checksum functionality after tidb fully support the feature.

asddongmen
asddongmen reviewed Apr 13, 2023
View reviewed changes
cdc/entry/mounter.go
} else {
decoder = m.decoder
}
if decoder == nil {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like this will never happen? can use panic instead of error here, which will make debugging easier.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer error, to avoid one single changefeed makes the whole server crashed

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 13, 2023
@3AceShowHand
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 0349cb8

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 13, 2023
@ti-chi-bot
Copy link
Member

@3AceShowHand: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

trigger some heavy tests which will not run always when PR updated.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Apr 13, 2023
@3AceShowHand
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: f3d7855

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 13, 2023
@3AceShowHand
Copy link
Contributor Author

/test verify

1 similar comment
@3AceShowHand
Copy link
Contributor Author

/test verify

@ti-chi-bot ti-chi-bot merged commit d35ab22 into pingcap:master Apr 13, 2023
zhangjinpeng87
zhangjinpeng87 reviewed May 8, 2023
View reviewed changes
cdc/entry/mounter.go
}

if checksum == extra {
log.Warn("extra checksum matched, this may happen the upstream TiDB is during the DDL"+
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change it to debug level, or the log will make ticdc out of disk when there are many ddls in TiDB.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Get it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhangjinpeng87 zhangjinpeng87 zhangjinpeng87 left review comments

@asddongmen asddongmen asddongmen approved these changes

@overvenus overvenus overvenus approved these changes

@sdojjy sdojjy Awaiting requested review from sdojjy

@Rustin170506 Rustin170506 Awaiting requested review from Rustin170506

@zyguan zyguan Awaiting requested review from zyguan

Assignees
No one assigned
Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add new unit test in the mounter to cover checksum calculation Mounter support checksum calculation
5 participants
@3AceShowHand @ti-chi-bot @overvenus @zhangjinpeng87 @asddongmen