Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests(ticdc): add exchange partition test to lossy DDL case #8912

Merged
merged 2 commits into from
May 8, 2023
Merged

tests(ticdc): add exchange partition test to lossy DDL case #8912

merged 2 commits into from
May 8, 2023

Conversation

Rustin170506
Copy link
Member

What problem does this PR solve?

Issue Number: close #8686

What is changed and how it works?

add exchange partition test to lossy DDL case

Check List

Tests

  • Integration test

Questions

Will it cause performance regression or break compatibility?

No

Do you need to update user documentation, design documentation or monitoring documentation?

No

Release note 

None

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 8, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • CharlesCheung96

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label May 8, 2023
@Rustin170506
Copy link
Member Author

/test all

@ti-chi-bot ti-chi-bot bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 8, 2023
@Rustin170506
Copy link
Member Author

/test all

@Rustin170506 Rustin170506 added the require-LGT1 Indicates that the PR requires an LGTM. label May 8, 2023
CharlesCheung96
CharlesCheung96 reviewed May 8, 2023
View reviewed changes
tests/integration_tests/lossy_ddl/data/prepare.sql
-- exchange partition
CREATE TABLE example16
(
a INT PRIMARY KEY
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whether it is better to insert one piece of data into each partition?

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 8, 2023
@Rustin170506
Copy link
Member Author

/merge

/test all

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 8, 2023

This pull request has been accepted and is ready to merge.

Commit hash: fa71644

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label May 8, 2023
@ti-chi-bot ti-chi-bot bot merged commit 4dc30e9 into pingcap:master May 8, 2023
Rustin170506 added a commit to ti-chi-bot/tiflow that referenced this pull request May 19, 2023
@Rustin170506
tests(ticdc): add exchange partition test to lossy DDL case (pingcap#…
9001ec1 
…8912)

close pingcap#8686
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CharlesCheung96 CharlesCheung96 CharlesCheung96 approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. require-LGT1 Indicates that the PR requires an LGTM. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Optimize the synchronization behavior of the lossy DDL operation
2 participants
@Rustin170506 @CharlesCheung96