Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metrics (ticdc): add changefeed status alert rules #9265

Merged
merged 1 commit into from
Jun 20, 2023

Conversation

asddongmen
Copy link
Contributor

@asddongmen asddongmen commented Jun 19, 2023

What problem does this PR solve?

Issue Number: ref #9266

What is changed and how it works?

image

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jun 19, 2023
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jun 20, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hi-rustin, nongfushanquan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm approved and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 20, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 20, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-06-20 01:43:23.347067264 +0000 UTC m=+67168.748317712: ☑️ agreed by nongfushanquan.
  • 2023-06-20 02:10:40.120238002 +0000 UTC m=+68805.521488451: ☑️ agreed by hi-rustin.

@asddongmen
Copy link
Contributor Author

asddongmen commented Jun 20, 2023

/hold I need to test it one more time.

@asddongmen
Copy link
Contributor Author

/unhold

@asddongmen
Copy link
Contributor Author

/merge

@asddongmen
Copy link
Contributor Author

/retest

2 similar comments
@asddongmen
Copy link
Contributor Author

/retest

@purelind
Copy link
Collaborator

/retest

@ti-chi-bot ti-chi-bot bot merged commit d52a23d into pingcap:master Jun 20, 2023
@asddongmen asddongmen added the needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. label Aug 22, 2023
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #9625.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants