-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
config(ticdc): enable-old-value always false if using avro or csv as the encoding protocol (#9079) #9318
config(ticdc): enable-old-value always false if using avro or csv as the encoding protocol (#9079) #9318
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
/test all |
/test all |
/merge |
@3AceShowHand: We have migrated to builtin Please use
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CharlesCheung96, sdojjy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@ti-chi-bot: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/test dm-integration-test |
/found community |
This is an automated cherry-pick of #9079
What problem does this PR solve?
Issue Number: close #9086
What is changed and how it works?
enableOldValue
by the sink scheme and encoding protocol. if using avro / csv, always false.enable-old-value
.enable-old-value
false, do not drop columns for the delete event at the mounter side.OnlyHandleKeyColumns
.Check List
Tests
Questions
Will it cause performance regression or break compatibility?
For changefeed using avro or csv, with
force-replicate
set to true, after upgrade, the changefeed cannot work normally.Do you need to update user documentation, design documentation or monitoring documentation?
Yes, update document to describe that
enable-old-value
is always false if usingavro
orcsv
as the encoding protocol.Release note