Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config(ticdc): enable-old-value always false if using avro or csv as the encoding protocol (#9079) #9318

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #9079

What problem does this PR solve?

Issue Number: close #9086

What is changed and how it works?

  • create / update changefeed, adjust the enableOldValue by the sink scheme and encoding protocol. if using avro / csv, always false.
  • upgrade scenario. owner boostrap adjust the enable-old-value.
  • enable-old-value false, do not drop columns for the delete event at the mounter side.
  • Open-Protocol / Canal-JSON / Maxwell / Craftl. When output delete event, generate output columns by the config OnlyHandleKeyColumns.
  • CSV always output all columns.

Check List

Tests

  • Unit test
  • Manual test (add detailed scripts or steps below)

Questions

Will it cause performance regression or break compatibility?

For changefeed using avro or csv, with force-replicate set to true, after upgrade, the changefeed cannot work normally.

Do you need to update user documentation, design documentation or monitoring documentation?

Yes, update document to describe that enable-old-value is always false if using avro or csv as the encoding protocol.

Release note

old value is always disabled for the changefeed using kafka sink or storage sink if using avro or csv as the encoding protocol

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR. labels Jun 30, 2023
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jun 30, 2023
@3AceShowHand
Copy link
Contributor

/test all

@ti-chi-bot ti-chi-bot bot deleted a comment from ti-chi-bot Jun 30, 2023
@3AceShowHand
Copy link
Contributor

/test all

@ti-chi-bot ti-chi-bot bot deleted a comment from ti-chi-bot Jun 30, 2023
@3AceShowHand
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 3, 2023

@3AceShowHand: We have migrated to builtin LGTM and approve plugins for reviewing.

Please use /approve when you want approve this pull request.

The changes announcement: LGTM plugin changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@3AceShowHand 3AceShowHand requested a review from sdojjy July 3, 2023 03:07
@ti-chi-bot ti-chi-bot bot added the approved label Jul 3, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 3, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CharlesCheung96, sdojjy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [CharlesCheung96,sdojjy]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Jul 3, 2023

@ti-chi-bot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-dm-integration-test d083bfa link unknown /test dm-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@3AceShowHand
Copy link
Contributor

/test dm-integration-test

@ti-chi-bot ti-chi-bot bot merged commit d8374fb into pingcap:release-7.1 Jul 3, 2023
@ti-chi-bot ti-chi-bot removed the cherry-pick-approved Cherry pick PR approved by release team. label Jul 24, 2023
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jul 24, 2023
@seiya-annie
Copy link

/found community

@ti-chi-bot ti-chi-bot bot added the report/community The community has encountered this bug. label Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. report/community The community has encountered this bug. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants