Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sink/mysql: add db read/write timeout #936

Merged
merged 8 commits into from
Sep 9, 2020
Merged

sink/mysql: add db read/write timeout #936

merged 8 commits into from
Sep 9, 2020

Conversation

amyangfei
Copy link
Contributor

What problem does this PR solve?

Add db read/write timeout in order to prevent database connection block by IO/timeout

What is changed and how it works?

Add readTimeout and writeTimeout to dsn string

Check List

Tests

  • Unit test
  • Integration test

Release note

  • No release note

@amyangfei amyangfei added the component/sink Sink component. label Sep 8, 2020
@amyangfei amyangfei added this to the v4.0.6 milestone Sep 8, 2020
@amyangfei
Copy link
Contributor Author

/run-integration-tests

@amyangfei
Copy link
Contributor Author

/run-integration-tests tidb=release-4.0 tikv=release-4.0 pd=release-4.0

3 similar comments
@amyangfei
Copy link
Contributor Author

/run-integration-tests tidb=release-4.0 tikv=release-4.0 pd=release-4.0

@amyangfei
Copy link
Contributor Author

/run-integration-tests tidb=release-4.0 tikv=release-4.0 pd=release-4.0

@amyangfei
Copy link
Contributor Author

/run-integration-tests tidb=release-4.0 tikv=release-4.0 pd=release-4.0

@codecov-commenter
Copy link

codecov-commenter commented Sep 8, 2020 •
edited
Loading

Codecov Report

Merging #936 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master       #936   +/-   ##
===========================================
  Coverage   33.4477%   33.4477%           
===========================================
  Files           100        100           
  Lines         11941      11941           
===========================================
  Hits           3994       3994           
  Misses         7558       7558           
  Partials        389        389

@amyangfei amyangfei added the status/ptal Could you please take a look? label Sep 8, 2020
@amyangfei
Copy link
Contributor Author

/run-integration-tests tidb=release-4.0 tikv=release-4.0 pd=release-4.0

1 similar comment
@amyangfei
Copy link
Contributor Author

/run-integration-tests tidb=release-4.0 tikv=release-4.0 pd=release-4.0

@overvenus
Copy link
Member

/lgtm

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 9, 2020
@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Sep 9, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Sep 9, 2020
@amyangfei amyangfei added the release-blocker This issue blocks a release. Please solve it ASAP. label Sep 9, 2020
@zier-one
Copy link
Contributor

zier-one commented Sep 9, 2020

/run-integration-tests tidb=release-4.0 tikv=release-4.0 pd=release-4.0

@zier-one
Copy link
Contributor

zier-one commented Sep 9, 2020

/run-integration-tests tidb=release-4.0 tikv=release-4.0 pd=release-4.0

@amyangfei
Copy link
Contributor Author

/run-integration-tests tidb=release-4.0 tikv=release-4.0 pd=release-4.0

1 similar comment
@amyangfei
Copy link
Contributor Author

/run-integration-tests tidb=release-4.0 tikv=release-4.0 pd=release-4.0

@zier-one
Copy link
Contributor

zier-one commented Sep 9, 2020

/run-integration-tests tidb=release-4.0 tikv=release-4.0 pd=release-4.0

1 similar comment
@zier-one
Copy link
Contributor

zier-one commented Sep 9, 2020

/run-integration-tests tidb=release-4.0 tikv=release-4.0 pd=release-4.0

@amyangfei amyangfei merged commit 050e444 into pingcap:master Sep 9, 2020
@amyangfei amyangfei deleted the db-timeout branch September 9, 2020 09:07
@amyangfei amyangfei mentioned this pull request Sep 29, 2020
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ti-srebot ti-srebot ti-srebot approved these changes

@zier-one zier-one zier-one approved these changes

Assignees
No one assigned
Labels
component/sink Sink component. release-blocker This issue blocks a release. Please solve it ASAP. status/LGT2 Indicates that a PR has LGTM 2. status/ptal Could you please take a look?
Projects
None yet
Milestone
v4.0.6
Development

Successfully merging this pull request may close these issues.
5 participants
@amyangfei @codecov-commenter @overvenus @zier-one @ti-srebot