Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

codec(ticdc): canal-json support large message handle #9384

Merged

Conversation

3AceShowHand
Copy link
Contributor

@3AceShowHand 3AceShowHand commented Jul 12, 2023

What problem does this PR solve?

Issue Number: close #9382, close #9383

What is changed and how it works?

  • canal-json encoder support encode message only have handle key columns
  • canal-json encoder support encode message with claim-check location

Check List

Tests

  • Unit test
  • Manual test (add detailed scripts or steps below)

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

`None`

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 12, 2023
@3AceShowHand 3AceShowHand changed the title [DNM]codec(ticdc): canal-json support large message handle codec(ticdc): canal-json support large message handle Jul 12, 2023
@ti-chi-bot ti-chi-bot bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jul 19, 2023
@3AceShowHand 3AceShowHand force-pushed the canal-json-support-large-message-handle branch from 6d9f964 to 4600e41 Compare July 19, 2023 05:59
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 19, 2023
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jul 19, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: asddongmen, sdojjy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 19, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 19, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-07-19 06:11:57.061798308 +0000 UTC m=+1090008.832137020: ☑️ agreed by sdojjy.
  • 2023-07-19 06:18:35.866545213 +0000 UTC m=+1090407.636883911: ☑️ agreed by asddongmen.

@ti-chi-bot ti-chi-bot bot merged commit 9a5bc3b into pingcap:master Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

canal-json encoder support claim-check interface canal-json encoder support only encode handle key columns
3 participants