Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kafka(ticdc): sarama admin client fetch metadata by cache (#9511) #9550

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #9511

What problem does this PR solve?

Issue Number: close #9504

What is changed and how it works?

  1. Improve the robustness of the Kafka admin client when the network is unstable by adjusting the following configuration settings:
config.Metadata.Retry.Max = 10 # Maximum number of retries when the admin client is getting metadata.
config.Metadata.Retry.Backoff = 200 * time.Millisecond # Retry backoff time when encountering a retryable error.
config.Metadata.Timeout = 2 * time.Minute # Maximum total retry time when the admin client is getting metadata.

config.Admin.Retry.Max = 10
config.Admin.Retry.Backoff = 200 * time.Millisecond
config.Admin.Timeout = 10 * time.Second
  1. The queryWithRetry method has been removed. Instead, when an unretryable error is encountered, the error will be returned as soon as possible. This allows sinkManager to reset the entire client and prevents the admin client from getting stuck in a retry loop if it encounters a unretryable network error.

Check List

Tests

  • Unit test
  • Manual test (add detailed scripts or steps below)

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

`None`

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added lgtm release-note-none Denotes a PR that doesn't merit a release note. labels Aug 11, 2023
@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels Aug 11, 2023
@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 11, 2023
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Aug 11, 2023
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 14, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: asddongmen, nongfushanquan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Aug 15, 2023
@ti-chi-bot ti-chi-bot bot merged commit 9055318 into pingcap:release-6.5 Aug 15, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants