Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kv(ticdc): remove backoff from newStream func #9771

Merged
merged 7 commits into from
Sep 26, 2023

Conversation

sdojjy
Copy link
Member

@sdojjy sdojjy commented Sep 19, 2023

What problem does this PR solve?

Issue Number: ref #9741

What is changed and how it works?

remove backoff from newStream func

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

 `None`.

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. and removed do-not-merge/needs-triage-completed labels Sep 19, 2023
@sdojjy sdojjy removed the needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. label Sep 19, 2023
@ti-chi-bot ti-chi-bot bot added needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. labels Sep 19, 2023
@sdojjy
Copy link
Member Author

sdojjy commented Sep 19, 2023

/test verify

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 20, 2023
cdc/kv/client.go Outdated Show resolved Hide resolved
@sdojjy
Copy link
Member Author

sdojjy commented Sep 21, 2023

/retest-required

1 similar comment
@sdojjy
Copy link
Member Author

sdojjy commented Sep 25, 2023

/retest-required

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 25, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 25, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: asddongmen, nongfushanquan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 25, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-09-20 03:36:45.934302122 +0000 UTC m=+661371.901890174: ☑️ agreed by nongfushanquan.
  • 2023-09-25 11:03:28.321817691 +0000 UTC m=+272798.040159895: ☑️ agreed by asddongmen.

@ti-chi-bot ti-chi-bot bot added the approved label Sep 25, 2023
@asddongmen
Copy link
Contributor

/retest

1 similar comment
@asddongmen
Copy link
Contributor

/retest

@sdojjy sdojjy changed the title kv(ticdc): remove backoff and add rate limiter for newStream func kv(ticdc): remove backoff for newStream func Sep 25, 2023
@sdojjy sdojjy changed the title kv(ticdc): remove backoff for newStream func kv(ticdc): remove backoff from newStream func Sep 25, 2023
…r-newStream

# Conflicts:
#	cdc/kv/shared_client.go
#	cdc/processor/processor.go
#	cdc/processor/sourcemanager/manager.go
#	cdc/puller/ddl_puller.go
@sdojjy
Copy link
Member Author

sdojjy commented Sep 26, 2023

/test dm-integration-test

1 similar comment
@sdojjy
Copy link
Member Author

sdojjy commented Sep 26, 2023

/test dm-integration-test

@ti-chi-bot ti-chi-bot bot merged commit 43848f2 into pingcap:master Sep 26, 2023
14 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #9809.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Sep 26, 2023
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #9810.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Sep 26, 2023
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@sdojjy sdojjy deleted the add-rate-limit-for-newStream branch September 26, 2023 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants